Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(11)

Issue 12088115: Merge 141357 (Closed)

Created:
8 years, 1 month ago by leviw_travelin_and_unemployed
Modified:
8 years, 1 month ago
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1364/
Visibility:
Public.

Description

Merge 141357 > [Chromium] WebPluginContainerImpl adding imbalanced touch handler refs > https://bugs.webkit.org/show_bug.cgi?id=108381 > > Reviewed by James Robinson. > > Source/WebKit/chromium: > > WebPluginContainerImpl would call Document::didAddTouchEventHandler every time the plugin requested > touch events. Some plugins make this request more than once, leading to an imbalance in Document's > touch event handler map, and a stale node pointer when the plugin is destroyed. This change > has WebPluginContainerImpl only add one ref for the plugin at a time. > > * src/WebPluginContainerImpl.cpp: > (WebKit::WebPluginContainerImpl::requestTouchEventType): > > Tools: > > * DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp: Adding an attribute that > tickles the case in WebPluginContainerImpl that imbalanced touch handler refs in Document. > > LayoutTests: > > * platform/chromium/plugins/re-request-touch-events-crash-expected.txt: Added. > * platform/chromium/plugins/re-request-touch-events-crash.html: Added. > TBR=leviw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141609

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
A + LayoutTests/platform/chromium/plugins/re-request-touch-events-crash.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/chromium/plugins/re-request-touch-events-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebKit/chromium/src/WebPluginContainerImpl.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M Tools/DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp View 5 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
leviw_travelin_and_unemployed
8 years, 1 month ago (2013-02-01 18:48:37 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698