Disable MMX intrinsics in qcms for x64 earlier than MSVC 2012

third_party/qcms/qcms.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'targets': [
     {
       'target_name': 'qcms',
       'product_name': 'qcms',
       'type': 'static_library',
@@ skipping 15 matching lines @@
           './src',
         ],
       },
       # Warning (sign-conversion) fixed upstream by large refactoring. Can be
       # removed on next roll.
       'msvs_disabled_warnings': [ 4018 ],
 
       'variables': {
         'conditions': [
           # For x86, turn off SSE2 for non-CrOS *nix Chrome builds.
+          # MSVC x64 doesn't support MMX until 2012.
           ['disable_sse2==1 or \
             (branding=="Chrome" and target_arch=="ia32" and \
-             os_posix==1 and OS!="mac" and chromeos==0)', {
+             os_posix==1 and OS!="mac" and chromeos==0) or \
+            (OS=="win" and target_arch=="x64" and MSVS_VERSION<"2012")', {

[scottmg, 2013/02/01 01:18:42]

items = ["2008", "2008e", "2010", "2010e", "2012", "2012e"]
for a in items:
  for b in items:
    print a, b, a < b

confirms that "2012e" is ! < "2012". That's pretty subtle, so at least add a
comment to the effect that "this disables for all previous to 2012 including
2012e"

[jschuh, 2013/02/01 01:32:04]

I already TBR'd... but I will add your comment.

             'qcms_use_sse': 0,
           }, {
             'qcms_use_sse': 1,
           }],
         ],
       },
 
       'conditions': [
         [ 'qcms_use_sse==1', {
           'defines': [
             'SSE2_ENABLE',
           ],
           'sources': [
             'src/transform-sse1.c',
             'src/transform-sse2.c',
           ],
         }],
       ],
     },
   ],
 }
 
 # Local Variables:
 # tab-width:2
 # indent-tabs-mode:nil
 # End:
 # vim: set expandtab tabstop=2 shiftwidth=2: