Second attempt to fix dart2js.bat so it looks for dart2js snapshot in right place.

Second attempt to fix dart2js.bat so it looks for dart2js snapshot in right place and propagates correct exit code back to caller.

BUG=dartbug.com/7663

Committed: https://code.google.com/p/dart/source/detail?r=20429

[aam-me, 2013-01-30 04:39:49]

Hi, Peter,

  I want to retry dart2js.bat snapshot fix I tried back in
https://chromiumcodereview.appspot.com/11740040/.
  This time around I added explicit "exit /b" to help get error code back to
caller. That might have been the issue that caused negative test case on Chrome
to fail(return error code 0).

  Please, take a look when you have a second.

Thank you.

[aam-me, 2013-03-17 04:07:07]

Hi Peter,

  hope you have some time to look at this change.
  With snapshots-enabled dart2js test suite with 5971 tests runs about 12%
faster on my machine(11m50s vs 13m27s).

Thank you.

[ahe, 2013-03-17 22:23:22]

Martin, Kasper, can you take a look at this?

Martin, I know you don't work on dart2js, but I think you understand this kind
of stuff.

[kasperl, 2013-03-18 10:46:59]

https://chromiumcodereview.appspot.com/12088067/diff/7001/sdk/bin/dart2js.bat
File sdk/bin/dart2js.bat (right):

https://chromiumcodereview.appspot.com/12088067/diff/7001/sdk/bin/dart2js.bat...
sdk/bin/dart2js.bat:35: set EXTRA_VM_OPTIONS=%EXTRA_VM_OPTIONS%
--no_use_inlining
This seems outdated.

[aam-me, 2013-03-18 11:31:52]

Thank you, Kasper!

PTAL

https://chromiumcodereview.appspot.com/12088067/diff/7001/sdk/bin/dart2js.bat
File sdk/bin/dart2js.bat (right):

https://chromiumcodereview.appspot.com/12088067/diff/7001/sdk/bin/dart2js.bat...
sdk/bin/dart2js.bat:35: set EXTRA_VM_OPTIONS=%EXTRA_VM_OPTIONS%
--no_use_inlining
Done. Thanks!

[kustermann, 2013-03-18 16:15:30]

My bat scripting skills are not really good. But as far as I see it, it looks
good.

A general question: Why is this symlink complexity needed?

https://chromiumcodereview.appspot.com/12088067/diff/15001/sdk/bin/dart2js.bat
File sdk/bin/dart2js.bat (right):

https://chromiumcodereview.appspot.com/12088067/diff/15001/sdk/bin/dart2js.ba...
sdk/bin/dart2js.bat:12: for %%i in ("%RETURNED_BIN_DIR%") do set BIN_DIR=%%~fi
Why do you use '%%' instead of '%'?

https://chromiumcodereview.appspot.com/12088067/diff/15001/sdk/bin/dart2js.ba...
sdk/bin/dart2js.bat:18: set DART=%BIN_DIR%\dart
To make it clearer you could use "dart.bat" here.

[aam-me, 2013-03-18 17:19:10]

On 2013/03/18 16:15:30, kustermann wrote:
> My bat scripting skills are not really good. But as far as I see it, it looks
> good.
> 
> A general question: Why is this symlink complexity needed?

On Mac and Linux folks can symlink $BIN_DIR folder.
Until this change on Windows they can't - this "%SCRIPTPATH%..\lib\" will break.

[aam-me, 2013-03-18 17:20:23]

Thank you, Martin.

See my comments below.

https://chromiumcodereview.appspot.com/12088067/diff/15001/sdk/bin/dart2js.bat
File sdk/bin/dart2js.bat (right):

https://chromiumcodereview.appspot.com/12088067/diff/15001/sdk/bin/dart2js.ba...
sdk/bin/dart2js.bat:12: for %%i in ("%RETURNED_BIN_DIR%") do set BIN_DIR=%%~fi
In cmd script(versus command line) you need to double up percent signs. So in
script %% becomes %, %%i becomes %i.

https://chromiumcodereview.appspot.com/12088067/diff/15001/sdk/bin/dart2js.ba...
sdk/bin/dart2js.bat:18: set DART=%BIN_DIR%\dart
It's actually dart.exe.
I don't have strong opinion on this, but do you still want to add .exe
extension?

[kustermann, 2013-03-21 23:12:16]

lgtm, and thanks for fixing it.

[aam-me, 2013-03-22 03:48:15]

Thank you, Martin.

Thanks to Peter for the heads up - Siva just recently updated the way how
snapshots are handled by dart. I picked up those updates in patchset 5.

PTAL!

[kustermann, 2013-03-22 16:37:25]

lgtm

https://chromiumcodereview.appspot.com/12088067/diff/14002/sdk/bin/dart2js.bat
File sdk/bin/dart2js.bat (right):

https://chromiumcodereview.appspot.com/12088067/diff/14002/sdk/bin/dart2js.ba...
sdk/bin/dart2js.bat:30: set EXTRA_VM_OPTIONS=%EXTRA_VM_OPTIONS%
I think this assignment is no longer needed.

[aam-me, 2013-03-22 23:53:31]

Thank you for the review, Martin.

https://chromiumcodereview.appspot.com/12088067/diff/14002/sdk/bin/dart2js.bat
File sdk/bin/dart2js.bat (right):

https://chromiumcodereview.appspot.com/12088067/diff/14002/sdk/bin/dart2js.ba...
sdk/bin/dart2js.bat:30: set EXTRA_VM_OPTIONS=%EXTRA_VM_OPTIONS%
You're right, thanks!

[aam-me, 2013-03-22 23:53:59]

Committed patchset #6 manually as r20429 (presubmit successful).