Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12088049: Merged all Chromoting Host code into remoting_core.dll (Windows). (Closed)

Created:
7 years, 10 months ago by alexeypa (please no reviews)
Modified:
7 years, 10 months ago
Reviewers:
Sergey Ulanov, scottmg
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Merged all Chromoting Host code into remoting_core.dll (Windows). Consolidated all installable Chromoting Host core into remoting_core.dll and converted all executables into thin wrappers around entry points exposed by remoting_core.dll. This reduces size of the installer by approximately 600KB. This is the 2nd attempt to land this CL. It was previously reverted at r179322. BUG=170200 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179373

Patch Set 1 #

Patch Set 2 : Fixed reference to '../media/media.gyp:media'. #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+676 lines, -776 lines) Patch
M remoting/branding_Chrome View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/branding_Chromium View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/host/continue_window_win.cc View 2 chunks +5 lines, -8 lines 0 comments Download
A remoting/host/desktop_process_main.h View 1 chunk +17 lines, -0 lines 0 comments Download
M remoting/host/desktop_process_main.cc View 5 chunks +50 lines, -46 lines 0 comments Download
M remoting/host/disconnect_window_win.cc View 1 chunk +1 line, -1 line 0 comments Download
A remoting/host/host_export.h View 1 chunk +24 lines, -0 lines 0 comments Download
D remoting/host/host_ui.rc View 1 chunk +0 lines, -100 lines 0 comments Download
D remoting/host/host_ui_resource.h View 1 chunk +0 lines, -27 lines 0 comments Download
M remoting/host/installer/win/chromoting.wxs View 8 chunks +25 lines, -14 lines 0 comments Download
M remoting/host/installer/win/parameters.json View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/host/plugin/host_plugin.cc View 1 chunk +0 lines, -3 lines 0 comments Download
D remoting/host/remoting_desktop.ver View 1 chunk +0 lines, -4 lines 0 comments Download
D remoting/host/remoting_host_me2me.ver View 1 chunk +0 lines, -4 lines 0 comments Download
A remoting/host/remoting_me2me_host.h View 1 chunk +17 lines, -0 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 7 chunks +46 lines, -58 lines 0 comments Download
M remoting/host/verify_config_window_win.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/verify_config_window_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/video_scheduler.cc View 1 chunk +1 line, -1 line 0 comments Download
A remoting/host/win/core.cc View 1 chunk +14 lines, -0 lines 0 comments Download
A + remoting/host/win/core.rc View 3 chunks +32 lines, -42 lines 0 comments Download
A + remoting/host/win/core_resource.h View 2 chunks +19 lines, -4 lines 0 comments Download
A remoting/host/win/daemon_process_entry_point.cc View 1 chunk +14 lines, -0 lines 0 comments Download
A remoting/host/win/daemon_process_main.h View 1 chunk +17 lines, -0 lines 0 comments Download
A remoting/host/win/daemon_process_main.cc View 1 chunk +89 lines, -0 lines 0 comments Download
A remoting/host/win/desktop_process_entry_point.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M remoting/host/win/elevated_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
D remoting/host/win/elevated_controller.rc View 1 chunk +0 lines, -69 lines 0 comments Download
A remoting/host/win/elevated_controller_entry_point.cc View 1 chunk +14 lines, -0 lines 0 comments Download
A remoting/host/win/elevated_controller_module.h View 1 chunk +17 lines, -0 lines 0 comments Download
M remoting/host/win/elevated_controller_module.cc View 4 chunks +10 lines, -12 lines 0 comments Download
D remoting/host/win/elevated_controller_resource.h View 1 chunk +0 lines, -19 lines 0 comments Download
A remoting/host/win/host_process_entry_point.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M remoting/host/win/host_service.cc View 5 chunks +1 line, -62 lines 0 comments Download
D remoting/host/win/host_service.rc View 1 chunk +0 lines, -80 lines 0 comments Download
D remoting/host/win/host_service_resource.h View 1 chunk +0 lines, -21 lines 0 comments Download
A remoting/host/win/remoting_core.ver View 1 chunk +4 lines, -0 lines 0 comments Download
A + remoting/host/win/remoting_desktop.ver View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/host/win/remoting_host.ver View 0 chunks +-1 lines, --1 lines 0 comments Download
M remoting/remoting.gyp View 1 2 18 chunks +224 lines, -200 lines 0 comments Download
M remoting/version.rc.version View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
alexeypa (please no reviews)
PTAL. #1 is the original change that got reverted. #2 is the fix.
7 years, 10 months ago (2013-01-29 18:49:52 UTC) #1
Sergey Ulanov
lgtm
7 years, 10 months ago (2013-01-29 18:56:59 UTC) #2
scottmg
lgtm
7 years, 10 months ago (2013-02-01 19:18:21 UTC) #3
scottmg
7 years, 10 months ago (2013-02-01 19:19:46 UTC) #4
Message was sent while issue was closed. 
On 2013/02/01 19:18:21, scottmg wrote:
> lgtm

Bah, ignore me.

Powered by Google App Engine
This is Rietveld 408576698