chrome/browser/ui/sync/one_click_signin_helper.cc - Issue 12088040: Add a SigninAllowed policy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/sync/one_click_signin_helper.cc

Issue 12088040: Add a SigninAllowed policy. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add tests and link UpdateLogin to kSigninAllowed pref. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/sync/one_click_signin_helper.cc

diff --git a/chrome/browser/ui/sync/one_click_signin_helper.cc b/chrome/browser/ui/sync/one_click_signin_helper.cc

index c3524fd0f3cae9456c51804ff38d786520ea1e44..2dfcded92db6ccc3397157892143564a0c936f93 100644

--- a/chrome/browser/ui/sync/one_click_signin_helper.cc

+++ b/chrome/browser/ui/sync/one_click_signin_helper.cc

@@ -390,7 +390,7 @@ bool OneClickSigninHelper::CanOffer(content::WebContents* web_contents,

Profile* profile =

Profile::FromBrowserContext(web_contents->GetBrowserContext());

- if (!profile)

+ if (!profile || !profile->IsSigninAllowed())

return false;

if (can_offer_for == CAN_OFFER_FOR_INTERSTITAL_ONLY &&

@@ -499,6 +499,9 @@ OneClickSigninHelper::Offer OneClickSigninHelper::CanOfferOnIOThreadImpl(

if (io_data->is_incognito())

return DONT_OFFER;

+ if (!SigninManager::IsSigninAllowedOnIOThread(io_data))

+ return DONT_OFFER;

if (!io_data->reverse_autologin_enabled()->GetValue())

return DONT_OFFER;