Add a SigninAllowed policy.

chrome/browser/ui/webui/options/browser_options_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/browser_options_handler.h"
 
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 125 matching lines @@
   cloud_print_connector_ui_enabled_ = true;
 #endif
 }
 
 BrowserOptionsHandler::~BrowserOptionsHandler() {
   ProfileSyncService* sync_service(ProfileSyncServiceFactory::
       GetInstance()->GetForProfile(Profile::FromWebUI(web_ui())));
   if (sync_service)
     sync_service->RemoveObserver(this);
 
+  SigninManager* signin =
+      SigninManagerFactory::GetInstance()->GetForProfile(
+          Profile::FromWebUI(web_ui()));
+  if (signin)
+    signin->RemoveSigninPrefObserver(this);
+
   if (default_browser_worker_.get())
     default_browser_worker_->ObserverDestroyed();
   if (template_url_service_)
     template_url_service_->RemoveObserver(this);
   // There may be pending file dialogs, we need to tell them that we've gone
   // away so they don't try and call back to us.
   if (select_folder_dialog_.get())
     select_folder_dialog_->ListenerDestroyed();
 }
 
@@ skipping 413 matching lines @@
 #endif
 }
 
 void BrowserOptionsHandler::OnStateChanged() {
   web_ui()->CallJavascriptFunction("BrowserOptions.updateSyncState",
                                    *GetSyncStateDictionary());
 
   SendProfilesInfo();
 }
 
+void BrowserOptionsHandler::OnSigninAllowedPrefChange(bool signin_allowed) {
+  web_ui()->CallJavascriptFunction("BrowserOptions.updateSyncState",
+                                   *GetSyncStateDictionary());
+
+  SendProfilesInfo();
+}
+
 void BrowserOptionsHandler::PageLoadStarted() {
   page_initialized_ = false;
 }
 
 void BrowserOptionsHandler::InitializeHandler() {
   Profile* profile = Profile::FromWebUI(web_ui());
   PrefService* prefs = profile->GetPrefs();
 
   ProfileSyncService* sync_service(
       ProfileSyncServiceFactory::GetInstance()->GetForProfile(profile));
   if (sync_service)
     sync_service->AddObserver(this);
 
+  SigninManager* signin =
+      SigninManagerFactory::GetInstance()->GetForProfile(profile);
+  if (signin)
+    signin->AddSigninPrefObserver(this);
+
   // Create our favicon data source.
   content::URLDataSource::Add(
       profile, new FaviconSource(profile, FaviconSource::FAVICON));
 
   default_browser_policy_.Init(
       prefs::kDefaultBrowserSettingEnabled,
       g_browser_process->local_state(),
       base::Bind(&BrowserOptionsHandler::UpdateDefaultBrowserState,
                  base::Unretained(this)));
 
@@ skipping 448 matching lines @@
     web_ui()->CallJavascriptFunction("BrowserOptions.updateAccountPicture",
                                      email_value);
   }
 }
 #endif
 
 scoped_ptr<DictionaryValue> BrowserOptionsHandler::GetSyncStateDictionary() {
   scoped_ptr<DictionaryValue> sync_status(new DictionaryValue);
   ProfileSyncService* service(ProfileSyncServiceFactory::
       GetInstance()->GetForProfile(Profile::FromWebUI(web_ui())));
-  sync_status->SetBoolean("syncSystemEnabled", !!service);
+  SigninManager* signin = SigninManagerFactory::GetForProfile(
+      Profile::FromWebUI(web_ui()));
+  sync_status->SetBoolean("syncSystemEnabled",
+                          !!service && (!signin || signin->IsSigninAllowed()));

[Andrew T Wilson (Slow), 2013/02/04 15:41:48]

I don't think that signin can be null here so no need to check for it. If you
want to add a DCHECK(signin) that's fine.

[Andrew T Wilson (Slow), 2013/02/05 08:58:53]

Also, I'm changing the JS code to not hide the signin UI when sync is disabled.
So you'll want to pass a separate signinDisabled flag to browser_options.js and
use that to hide the signin UI rather than trying to piggy-back on
syncSystemEnabled.

[Adrian Kuegel, 2013/02/05 10:55:15]

Done.

   if (!service)
     return sync_status.Pass();
 
   sync_status->SetBoolean("setupCompleted",
                           service->HasSyncSetupCompleted());
   sync_status->SetBoolean("setupInProgress", service->FirstSetupInProgress());
 
   string16 status_label;
   string16 link_label;
-  SigninManager* signin = SigninManagerFactory::GetForProfile(
-      Profile::FromWebUI(web_ui()));
 
   bool status_has_error = sync_ui_util::GetStatusLabels(
       service, *signin, sync_ui_util::WITH_HTML, &status_label, &link_label) ==
           sync_ui_util::SYNC_ERROR;
   sync_status->SetString("statusText", status_label);
   sync_status->SetString("actionLinkText", link_label);
   sync_status->SetBoolean("hasError", status_has_error);
 
   sync_status->SetBoolean("managed", service->IsManaged());
   sync_status->SetBoolean("signedIn",
@@ skipping 332 matching lines @@
         l10n_util::GetStringUTF16(IDS_PRODUCT_NAME));
   }
   StringValue label(label_str);
 
   web_ui()->CallJavascriptFunction(
       "BrowserOptions.setupProxySettingsSection", disabled, label);
 #endif  // !defined(OS_CHROMEOS)
 }
 
 }  // namespace options