Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Issue 12088014: Revert 179081 (Closed)

Created:
7 years, 11 months ago by James Cook
Modified:
7 years, 11 months ago
Reviewers:
tfarina
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 179081 > Make build/temp_gyp/googleurl a 'none' target that depends on the 'real' src/googleurl/googleurl.gyp > > This is the first step to change all the references from build/temp_gyp/ to > the new location in src/googleurl/ > > R=brettw@chromium.org,rsleevi@chromium.org > TBR=darin@chromium.org # for gyp change. > > Review URL: https://chromiumcodereview.appspot.com/12073003 TBR=tfarina@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179085

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -31 lines) Patch
M build/all.gyp View 13 chunks +18 lines, -18 lines 0 comments Download
M build/temp_gyp/googleurl.gyp View 2 chunks +93 lines, -6 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
James Cook
7 years, 11 months ago (2013-01-27 06:52:36 UTC) #1
tfarina
On Sun, Jan 27, 2013 at 4:52 AM, <jamescook@chromium.org> wrote: > Reviewers: tfarina, > Please ...
7 years, 11 months ago (2013-01-27 12:17:50 UTC) #2
tfarina
7 years, 11 months ago (2013-01-27 18:48:48 UTC) #3
On Sun, Jan 27, 2013 at 10:17 AM, Thiago Farina <tfarina@chromium.org> wrote:
> On Sun, Jan 27, 2013 at 4:52 AM,  <jamescook@chromium.org> wrote:
>> Reviewers: tfarina,
>>
> Please always include the reason why you are reverting a patch!
> Otherwise it's impossible to figure out why it was reverted!
>
Sorry, 'impossible' is too heavy. But certainly makes it harder to
find what caused the patch to be reverted.

-- 
Thiago

Powered by Google App Engine
This is Rietveld 408576698