Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Unified Diff: tests/presubmit_unittest.py

Issue 1208743002: Changes to improve multiprocessing PRESUBMIT support in Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: fix tests Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/presubmit_unittest.py
diff --git a/tests/presubmit_unittest.py b/tests/presubmit_unittest.py
index 3bec7733c92ffaca5fd5396e927a7b716d34eae0..87832d46c3eeb5c27b3de5f59742649535587531 100755
--- a/tests/presubmit_unittest.py
+++ b/tests/presubmit_unittest.py
@@ -2529,13 +2529,15 @@ class CannedChecksUnittest(PresubmitTestsBase):
pylintrc = os.path.join(_ROOT, 'pylintrc')
CommHelper(input_api,
- ['pyyyyython', pylint, '--args-on-stdin', '--disable=cyclic-import',
- '--jobs=2'],
- env=mox.IgnoreArg(), stdin='file1.py\n--rcfile=%s' % pylintrc)
+ ['pyyyyython', pylint, '--args-on-stdin'],
+ env=mox.IgnoreArg(), stdin=
+ '--rcfile=%s\n--disable=cyclic-import\n--jobs=2\nfile1.py'
+ % pylintrc)
CommHelper(input_api,
- ['pyyyyython', pylint, '--args-on-stdin', '--disable=all',
- '--enable=cyclic-import'],
- env=mox.IgnoreArg(), stdin='file1.py\n--rcfile=%s' % pylintrc)
+ ['pyyyyython', pylint, '--args-on-stdin'],
+ env=mox.IgnoreArg(), stdin=
+ '--rcfile=%s\n--disable=all\n--enable=cyclic-import\nfile1.py'
+ % pylintrc)
self.mox.ReplayAll()
results = presubmit_canned_checks.RunPylint(

Powered by Google App Engine
This is Rietveld 408576698