Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Unified Diff: content/browser/renderer_host/touchpad_tap_suppression_controller.h

Issue 12087140: Suppress touchscreen tap immediately after a GestureFlingCancel (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/touchpad_tap_suppression_controller.h
diff --git a/content/browser/renderer_host/tap_suppression_controller.h b/content/browser/renderer_host/touchpad_tap_suppression_controller.h
similarity index 77%
rename from content/browser/renderer_host/tap_suppression_controller.h
rename to content/browser/renderer_host/touchpad_tap_suppression_controller.h
index 84a7c4821dfd6dc4a90e88d7cce2f3099f74f30d..905a82d61eb8124d3603c292782a8fd3c1d2d2a0 100644
--- a/content/browser/renderer_host/tap_suppression_controller.h
+++ b/content/browser/renderer_host/touchpad_tap_suppression_controller.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CONTENT_BROWSER_RENDERER_HOST_TAP_SUPPRESSION_CONTROLLER_H_
-#define CONTENT_BROWSER_RENDERER_HOST_TAP_SUPPRESSION_CONTROLLER_H_
+#ifndef CONTENT_BROWSER_RENDERER_HOST_TOUCHPAD_TAP_SUPPRESSION_CONTROLLER_H_
+#define CONTENT_BROWSER_RENDERER_HOST_TOUCHPAD_TAP_SUPPRESSION_CONTROLLER_H_
#include "base/time.h"
#include "base/timer.h"
@@ -18,11 +18,11 @@ class RenderWidgetHostImpl;
// immediately following the dispatch of a WebGestureFlingCancel event.
// Only mousedown/mouseup of sufficient speed and within a specified time
// window after a WebGestureFlingCancel are suppressed.
-class TapSuppressionController {
+class TouchpadTapSuppressionController {
public:
- explicit TapSuppressionController(RenderWidgetHostImpl*);
- ~TapSuppressionController();
+ explicit TouchpadTapSuppressionController(RenderWidgetHostImpl*);
+ ~TouchpadTapSuppressionController();
// Called on the arrival of a mouse up event. Returns true if the hosting RWHV
// should suppress the remaining mouseup handling at this time.
@@ -30,8 +30,7 @@ class TapSuppressionController {
// Called on a mouse down. Returns true if the hosting RWHV should not
// continue with handling the mouse down event at this time.
- bool ShouldDeferMouseDown(
- const WebKit::WebMouseEvent& event);
+ bool ShouldDeferMouseDown(const WebKit::WebMouseEvent& event);
// Called on an ack of WebGestureFlingCancel event. |processed| is true when
// the GestureFlingCancel actually stopped a fling and therefore should
@@ -58,7 +57,7 @@ class TapSuppressionController {
// Only a RenderWidgetHostViewImpl can own an instance.
RenderWidgetHostImpl* render_widget_host_;
- base::OneShotTimer<TapSuppressionController> mouse_down_timer_;
+ base::OneShotTimer<TouchpadTapSuppressionController> mouse_down_timer_;
WebKit::WebMouseEvent stashed_mouse_down_;
State state_;
@@ -67,9 +66,9 @@ class TapSuppressionController {
// become available post http://crbug.com/119556.
base::TimeTicks fling_cancel_time_;
- DISALLOW_COPY_AND_ASSIGN(TapSuppressionController);
+ DISALLOW_COPY_AND_ASSIGN(TouchpadTapSuppressionController);
};
-} // namespace content
+} // namespace content
-#endif // CONTENT_BROWSER_RENDERER_HOST_TAP_SUPPRESSION_CONTROLLER_H_
+#endif // CONTENT_BROWSER_RENDERER_HOST_TOUCHPAD_TAP_SUPPRESSION_CONTROLLER_H_

Powered by Google App Engine
This is Rietveld 408576698