Suppress touchscreen tap immediately after a GestureFlingCancel

content/browser/renderer_host/tap_suppression_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/tap_suppression_controller.h"
 
 #include "base/debug/trace_event.h"
 #include "base/logging.h"
 #include "content/browser/renderer_host/tap_suppression_controller_client.h"
 
@@ skipping 15 matching lines @@
       state_ = GFC_IN_PROGRESS;
       break;
     case TAP_DOWN_STASHED:
       break;
   }
 }
 
 void TapSuppressionController::GestureFlingCancelAck(bool processed) {
   base::TimeTicks event_time = Now();
   switch (state_) {
     case NOTHING:

[mohsen, 2013/03/21 14:49:32]

Here, I am allowing GFC Ack to arrive when we are in NOTHING state. That's
because the Ack for a GFC can arrive after we receive the corresponding tap-down
and tap-up, in which case we will be back in NOTHING state.

[rjkroege, 2013/03/21 17:17:01]

I'm find with this but per the discussion about an overcomplicated code in
events, this is just one more datum demonstrating the need for some serious
refactoring here.

-      NOTREACHED() << "GFC_ACK without a GFC";
       break;
     case GFC_IN_PROGRESS:
       if (processed)
         fling_cancel_time_ = event_time;
       state_ = LAST_CANCEL_STOPPED_FLING;
       break;
     case TAP_DOWN_STASHED:
       if (!processed) {
         TRACE_EVENT0("browser",
                      "TapSuppressionController::GestureFlingCancelAck");
@@ skipping 93 matching lines @@
     case TAP_DOWN_STASHED:
       TRACE_EVENT0("browser",
                    "TapSuppressionController::TapDownTimerExpired");
       client_->ForwardStashedTapDownSkipDeferral();
       state_ = NOTHING;
       break;
   }
 }
 
 }  // namespace content