Issue 12087129: Move kChromeSearchScheme out of content since it's a chrome feature.

Issue 12087129: Move kChromeSearchScheme out of content since it's a chrome feature. (Closed)

Created:
7 years, 10 months ago by jam

Modified:
7 years, 10 months ago

Reviewers:
dhollowa

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Move kChromeSearchScheme out of content since it's a chrome feature. Also remove ContentBrowserClient::RenderProcessHostDeleted since it duplicates an existing notification. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180150

Patch Set 1 : #

Patch Set 2 : #

Total comments: 2

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -33 lines)			Patch
M	chrome/browser/chrome_content_browser_client.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/chrome_content_browser_client.cc	View		1 chunk	+0 lines, -12 lines	0 comments	Download
M	chrome/browser/instant/instant_service.h	View		3 chunks	+10 lines, -2 lines	2 comments	Download
M	chrome/browser/instant/instant_service.cc	View	1	3 chunks	+14 lines, -4 lines	0 comments	Download
M	chrome/common/chrome_content_client.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/url_constants.h	View		2 chunks	+3 lines, -4 lines	0 comments	Download
M	chrome/common/url_constants.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_process_host_impl.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	content/common/url_schemes.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	content/public/browser/content_browser_client.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	content/public/common/url_constants.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	content/public/common/url_constants.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

dhollowa

Thanks John. https://codereview.chromium.org/12087129/diff/9004/chrome/browser/instant/instant_service.h File chrome/browser/instant/instant_service.h (right): https://codereview.chromium.org/12087129/diff/9004/chrome/browser/instant/instant_service.h#newcode36 chrome/browser/instant/instant_service.h:36: const content::NotificationSource& source, nit: indent

7 years, 10 months ago (2013-02-01 16:56:11 UTC) #2

jam

7 years, 10 months ago (2013-02-01 17:09:14 UTC) #4

https://codereview.chromium.org/12087129/diff/9004/chrome/browser/instant/ins...
File chrome/browser/instant/instant_service.h (right):

https://codereview.chromium.org/12087129/diff/9004/chrome/browser/instant/ins...
chrome/browser/instant/instant_service.h:36: const content::NotificationSource&
source,
On 2013/02/01 16:56:11, dhollowa wrote:
> nit: indent

Done.

Expand Messages | Collapse Messages