Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Unified Diff: chrome/browser/resources/options/language_add_language_overlay.js

Issue 12087105: Use drop-down UI for "add language". (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/language_add_language_overlay.js
diff --git a/chrome/browser/resources/options/language_add_language_overlay.js b/chrome/browser/resources/options/language_add_language_overlay.js
index d5ebf93554ebc669ecb22d4790b391333da2a91b..526ca4836001e676969b60888972d786810dba38 100644
--- a/chrome/browser/resources/options/language_add_language_overlay.js
+++ b/chrome/browser/resources/options/language_add_language_overlay.js
@@ -48,21 +48,10 @@ cr.define('options', function() {
displayText += ' - ' + language.nativeDisplayName;
}
- if (cr.isChromeOS) {
- var button = document.createElement('button');
- button.className = 'link-button';
- button.textContent = displayText;
- button.languageCode = language.code;
- var li = document.createElement('li');
- li.languageCode = language.code;
- li.appendChild(button);
- addLanguageList.appendChild(li);
- } else {
- var option = document.createElement('option');
- option.value = language.code;
- option.textContent = displayText;
- addLanguageList.appendChild(option);
- }
+ var option = document.createElement('option');
Dan Beam 2013/02/01 19:38:10 nit: cr.doc.createElement() or this.ownerDocument.
Seigo Nonaka 2013/02/04 06:10:45 Done.
+ option.value = language.code;
+ option.textContent = displayText;
+ addLanguageList.appendChild(option);
}
},
};

Powered by Google App Engine
This is Rietveld 408576698