Issue 12087104: Prevent calling GetProcId with a null process handle in PpapiPluginProcessHost::RequestPluginChannel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12087104: Prevent calling GetProcId with a null process handle in PpapiPluginProcessHost::RequestPluginChannel (Closed)

Created:
7 years, 10 months ago by robertshield

Modified:
7 years, 10 months ago

Reviewers:
brettw

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, grt (UTC plus 2)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Prevent calling GetProcId with a null process handle in PpapiPluginProcessHost::RequestPluginChannel BUG=170737 TEST=Debug Chrome doesn't crash immediately. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180344

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	content/browser/ppapi_plugin_process_host.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

robertshield

Hi Brett, Trunk debug Chrome currently NOTREACHES soon after startup. This patch avoids that. Please ...

7 years, 10 months ago (2013-01-31 15:37:48 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertshield@chromium.org/12087104/1

7 years, 10 months ago (2013-02-01 19:44:39 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=106444

7 years, 10 months ago (2013-02-01 23:19:17 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertshield@chromium.org/12087104/1

7 years, 10 months ago (2013-02-04 00:50:18 UTC) #5

Message was sent while issue was closed.

Change committed as 180344

Expand Messages | Collapse Messages