Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1134)

Unified Diff: runtime/lib/array.dart

Issue 12087103: Revert "Rename mappedBy to map." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/yaml/lib/yaml_map.dart ('k') | runtime/lib/byte_array.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/array.dart
diff --git a/runtime/lib/array.dart b/runtime/lib/array.dart
index f72191dfb22b99fdfba04bf3dc9eb1ce523da503..e7c4bee5b9b9f28652adcc711b2e4d5d1dcff822 100644
--- a/runtime/lib/array.dart
+++ b/runtime/lib/array.dart
@@ -34,7 +34,6 @@ class _ObjectArray<E> implements List<E> {
"Cannot remove element of a non-extendable array");
}
- // Collection interface.
void removeAll(Iterable elements) {
throw new UnsupportedError(
"Cannot remove element of a non-extendable array");
@@ -55,7 +54,6 @@ class _ObjectArray<E> implements List<E> {
"Cannot remove element of a non-extendable array");
}
- // List interface.
void setRange(int start, int length, List<E> from, [int startFrom = 0]) {
if (length < 0) {
throw new ArgumentError("negative length $length");
@@ -86,7 +84,7 @@ class _ObjectArray<E> implements List<E> {
return list;
}
- // Iterable interface.
+ // Collection interface.
bool contains(E element) {
return IterableMixinWorkaround.contains(this, element);
@@ -100,12 +98,8 @@ class _ObjectArray<E> implements List<E> {
return IterableMixinWorkaround.joinList(this, separator);
}
- Iterable map(f(E element)) {
- return IterableMixinWorkaround.map(this, f);
- }
-
List mappedBy(f(E element)) {
- IterableMixinWorkaround.mappedByList(this, f);
+ return IterableMixinWorkaround.mappedByList(this, f);
}
reduce(initialValue, combine(previousValue, E element)) {
@@ -116,7 +110,7 @@ class _ObjectArray<E> implements List<E> {
return IterableMixinWorkaround.where(this, f);
}
- Iterable<E> take(int n) {
+ List<E> take(int n) {
return IterableMixinWorkaround.takeList(this, n);
}
@@ -124,7 +118,7 @@ class _ObjectArray<E> implements List<E> {
return IterableMixinWorkaround.takeWhile(this, test);
}
- Iterable<E> skip(int n) {
+ List<E> skip(int n) {
return IterableMixinWorkaround.skipList(this, n);
}
@@ -330,10 +324,6 @@ class _ImmutableArray<E> implements List<E> {
IterableMixinWorkaround.forEach(this, f);
}
- Iterable map(f(E element)) {
- return IterableMixinWorkaround.map(this, f);
- }
-
List mappedBy(f(E element)) {
return IterableMixinWorkaround.mappedByList(this, f);
}
@@ -350,7 +340,7 @@ class _ImmutableArray<E> implements List<E> {
return IterableMixinWorkaround.where(this, f);
}
- Iterable<E> take(int n) {
+ List<E> take(int n) {
return IterableMixinWorkaround.takeList(this, n);
}
@@ -358,7 +348,7 @@ class _ImmutableArray<E> implements List<E> {
return IterableMixinWorkaround.takeWhile(this, test);
}
- Iterable<E> skip(int n) {
+ List<E> skip(int n) {
return IterableMixinWorkaround.skipList(this, n);
}
« no previous file with comments | « pkg/yaml/lib/yaml_map.dart ('k') | runtime/lib/byte_array.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698