Issue 12087102: [Android WebView] Avoid detecting '(c)' as a copyright sign in lists.

Issue 12087102: [Android WebView] Avoid detecting '(c)' as a copyright sign in lists. (Closed)

Created:
7 years, 10 months ago by mnaganov (inactive)

Modified:
7 years, 10 months ago

Reviewers:
mkosiba (inactive)

CC:
chromium-reviews, android-webview-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Android WebView] Avoid detecting '(c)' as a copyright sign in lists. Add heuristics into the copyright scanner to avoid detecting '(c)' as a copyright sign, when it is used in C++ comments for making itemized lists, e.g.: // blah-blah (a) blah // (b) blah and (c) blah This removes all such false positives except one. BUG=161461 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179884

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Compare deltas correctly #

Total comments: 2

Patch Set 4 : Comments addressed #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -45 lines)			Patch
	M	android_webview/tools/find_copyrights.pl	View	1 2 3	3 chunks	+76 lines, -33 lines	0 comments	Download
	M	android_webview/tools/third_party_files_whitelist.txt	View	1	2 chunks	+0 lines, -12 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

mkosiba (inactive)

lgtm https://codereview.chromium.org/12087102/diff/6001/android_webview/tools/find_copyrights.pl File android_webview/tools/find_copyrights.pl (right): https://codereview.chromium.org/12087102/diff/6001/android_webview/tools/find_copyrights.pl#newcode98 android_webview/tools/find_copyrights.pl:98: # Remove C / C++ strings to avoid ...

7 years, 10 months ago (2013-01-31 14:39:48 UTC) #3

mnaganov (inactive)

https://codereview.chromium.org/12087102/diff/6001/android_webview/tools/find_copyrights.pl File android_webview/tools/find_copyrights.pl (right): https://codereview.chromium.org/12087102/diff/6001/android_webview/tools/find_copyrights.pl#newcode98 android_webview/tools/find_copyrights.pl:98: # Remove C / C++ strings to avoid false ...

7 years, 10 months ago (2013-01-31 14:53:03 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnaganov@chromium.org/12087102/10001

7 years, 10 months ago (2013-01-31 14:53:56 UTC) #5

Message was sent while issue was closed.

Change committed as 179884

Expand Messages | Collapse Messages