Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(942)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12087091: Move string tokenizer to base/strings. (Closed)

Created:
7 years, 10 months ago by brettw
Modified:
7 years, 10 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews
Visibility:
Public.

Description

Move string tokenizer to base/strings. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180211

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Total comments: 6

Patch Set 7 : sort #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -676 lines) Patch
M base/base.gyp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M base/base.gypi View 1 2 3 4 2 chunks +1 line, -1 line 0 comments Download
M base/debug/trace_event_impl.cc View 1 2 3 4 5 6 8 chunks +9 lines, -9 lines 0 comments Download
M base/process_util_linux.cc View 21 chunks +38 lines, -38 lines 0 comments Download
D base/string_tokenizer.h View 1 chunk +0 lines, -256 lines 0 comments Download
D base/string_tokenizer_unittest.cc View 1 chunk +0 lines, -230 lines 0 comments Download
A + base/strings/string_tokenizer.h View 2 chunks +7 lines, -3 lines 0 comments Download
A + base/strings/string_tokenizer_unittest.cc View 2 chunks +5 lines, -1 line 0 comments Download
M base/sys_info_chromeos.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/character_encoding.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/customization_document.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/system/name_value_pairs_parser.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/web_socket_proxy_controller.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/proxy/proxy_api_helpers.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_system.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/google_apis/fake_drive_service.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/history/thumbnail_database.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/importer/firefox_proxy_settings.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/language_usage_metrics.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/metrics/thread_watcher.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/metrics/thread_watcher_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/shell_integration_linux.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/browser_titlebar.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/auto_start_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/csp_validator.cc View 1 2 3 4 5 chunks +6 lines, -5 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M chrome_frame/html_utils.cc View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M chrome_frame/test/test_server.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/utils.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/network/network_util.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M content/app/android/library_loader_hooks.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/devtools/devtools_netlog_observer.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/common/android/address_parser_internal.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M content/gpu/gpu_info_collector_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/android/browsertests_apk/content_browser_tests_android.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/test_helper.cc View 1 2 3 4 5 6 3 chunks +4 lines, -4 lines 0 comments Download
M net/base/host_mapping_rules.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/base/mapped_host_resolver.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M net/base/net_util.cc View 1 2 3 4 5 6 3 chunks +5 lines, -5 lines 0 comments Download
M net/base/net_util_posix.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/base/x509_certificate_win.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M net/cookies/cookie_monster_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/cookies/cookie_store_unittest.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/cookies/cookie_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/dns/dns_hosts.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M net/ftp/ftp_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/http_auth.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/http/http_content_disposition.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M net/http/http_security_headers.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/http/http_util.h View 3 chunks +3 lines, -3 lines 0 comments Download
M net/http/http_util.cc View 1 2 3 4 5 6 5 chunks +7 lines, -6 lines 0 comments Download
M net/proxy/proxy_bypass_rules.cc View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M net/proxy/proxy_config.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/proxy/proxy_config_service_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/proxy/proxy_config_service_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/proxy/proxy_config_service_win.cc View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M net/proxy/proxy_list.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/proxy/proxy_resolver_v8.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M net/proxy/proxy_server.cc View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M net/websockets/websocket_handshake_handler.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/websockets/websocket_job.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M testing/android/native_test_launcher.cc View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M ui/base/gestures/gesture_sequence.cc View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M webkit/glue/webkit_glue.cc View 1 2 3 4 5 6 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
brettw
Basically search and replace. I fixed the namespaces in one base file and removed a ...
7 years, 10 months ago (2013-01-31 00:49:46 UTC) #1
viettrungluu
LGTM (assuming it builds) apart from include ordering. https://codereview.chromium.org/12087091/diff/13070/base/debug/trace_event_impl.cc File base/debug/trace_event_impl.cc (right): https://codereview.chromium.org/12087091/diff/13070/base/debug/trace_event_impl.cc#newcode19 base/debug/trace_event_impl.cc:19: #include ...
7 years, 10 months ago (2013-02-01 17:54:15 UTC) #2
viettrungluu
https://codereview.chromium.org/12087091/diff/13070/ui/base/gestures/gesture_sequence.cc File ui/base/gestures/gesture_sequence.cc (right): https://codereview.chromium.org/12087091/diff/13070/ui/base/gestures/gesture_sequence.cc#newcode13 ui/base/gestures/gesture_sequence.cc:13: #include "base/strings/string_tokenizer.h" Do you really need this include?
7 years, 10 months ago (2013-02-01 17:54:57 UTC) #3
viettrungluu
7 years, 10 months ago (2013-02-01 17:55:56 UTC) #4 
https://codereview.chromium.org/12087091/diff/13070/net/proxy/proxy_server.cc
File net/proxy/proxy_server.cc (right):

https://codereview.chromium.org/12087091/diff/13070/net/proxy/proxy_server.cc...
net/proxy/proxy_server.cc:10: #include "base/strings/string_tokenizer.h"
And this one? (Apparently, I hadn't looked at all the files yet.)

Powered by Google App Engine
This is Rietveld 408576698