runtime/bin/socket.cc - Issue 12087088: Fix Socket_WriteList to use the offset for external byte arrays.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/socket.cc

Issue 12087088: Fix Socket_WriteList to use the offset for external byte arrays. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/socket.cc

diff --git a/runtime/bin/socket.cc b/runtime/bin/socket.cc

index 1285f1363a17353ac579cf555048d2cefd2c5e12..c42d2cf6a9e6dc511b0e915063aebeae165c0e61 100644

--- a/runtime/bin/socket.cc

+++ b/runtime/bin/socket.cc

@@ -186,6 +186,7 @@ void FUNCTION_NAME(Socket_WriteList)(Dart_NativeArguments args) {

if (Dart_IsError(result)) {

Dart_PropagateError(result);

}

+ buffer = static_cast<void*>((static_cast<char*>(buffer) + offset));

Søren Gjesse 2013/01/30 16:11:30 uint8_t instead of char*.

Mads Ager (google) 2013/01/30 16:14:25 Done.

bytes_written = Socket::Write(socket, buffer, length);

if (bytes_written > 0) total_bytes_written = bytes_written;

} else {

« no previous file with comments | « no previous file | no next file » | no next file with comments »