Create unit-test for exiting context menus via mouse button

chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/compiler_specific.h"
 #include "base/string_number_conversions.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"
@@ skipping 51 matching lines @@
 class TestingPageNavigator : public PageNavigator {
  public:
   virtual WebContents* OpenURL(const OpenURLParams& params) OVERRIDE {
     url_ = params.url;
     return NULL;
   }
 
   GURL url_;
 };
 
+class TestForMenuExitView : public views::View {
+ public:
+  TestForMenuExitView() : press_count_(0) {
+  }
+  virtual bool OnMousePressed(const ui::MouseEvent& event) OVERRIDE {
+    ++press_count_;
+    return true;
+  }
+  int press_count() const {
+    return press_count_;
+  }
+
+ private:
+  int press_count_;
+};

[sky, 2013/01/30 14:53:04]

DISALLOW_...

[sschmitz, 2013/01/30 20:43:58]

Done.

+
 }  // namespace
 
 // Base class for event generating bookmark view tests. These test are intended
 // to exercise View's menus, but that's easier done with BookmarkBarView rather
 // than View's menu itself.
 //
 // SetUp creates a bookmark model with the following structure.
 // All folders are in upper case, all URLs in lower case.
 // F1
 //   f1a
@@ skipping 17 matching lines @@
 //   the names f1-f100.
 //
 // Subclasses should be sure and invoke super's implementation of SetUp and
 // TearDown.
 class BookmarkBarViewEventTestBase : public ViewEventTestBase {
  public:
   BookmarkBarViewEventTestBase()
       : ViewEventTestBase(),
         model_(NULL),
         bb_view_(NULL),
+        test_for_menu_exit_flag_(false),
+        test_for_menu_exit_view_(NULL),
+        file_thread_(BrowserThread::FILE, MessageLoop::current()) {
+  }
+  explicit BookmarkBarViewEventTestBase(bool test_flag)
+      : ViewEventTestBase(),
+        model_(NULL),
+        bb_view_(NULL),
+        test_for_menu_exit_flag_(test_flag),
+        test_for_menu_exit_view_(NULL),
         file_thread_(BrowserThread::FILE, MessageLoop::current()) {
   }
 
   virtual void SetUp() {
     bookmark_utils::DisableBookmarkBarViewAnimationsForTesting(true);
 
     profile_.reset(new TestingProfile());
     profile_->CreateBookmarkModel(true);
     profile_->BlockUntilBookmarkModelLoaded();
     profile_->GetPrefs()->SetBoolean(prefs::kShowBookmarkBar, true);
@@ skipping 17 matching lines @@
     // GetPreferredSize hard codes a width of 1. For that reason we add the
     // BookmarkBarView to a dumby view as the parent.
     //
     // This code looks a bit hacky, but I've written it so that it shouldn't
     // be dependant upon any of the layout code in BookmarkBarView. Instead
     // we brute force search for a size that triggers the overflow button.
     views::View tmp_parent;
 
     tmp_parent.AddChildView(bb_view_.get());
 
-    bb_view_pref_ = bb_view_->GetPreferredSize();
-    bb_view_pref_.set_width(1000);
-    views::TextButton* button = GetBookmarkButton(4);
-    while (button->visible()) {
-      bb_view_pref_.set_width(bb_view_pref_.width() - 25);
-      bb_view_->SetBounds(0, 0, bb_view_pref_.width(), bb_view_pref_.height());
+    if (!test_for_menu_exit_flag_) {

[sky, 2013/01/30 14:53:04]

Why does this need to be here and not in your test? I much prefer moving to test
as then you don't need to modify constructor or change the base class in any
way.

[sschmitz, 2013/01/30 20:43:58]

Done.

+      bb_view_pref_ = bb_view_->GetPreferredSize();
+      bb_view_pref_.set_width(1000);
+      views::TextButton* button = GetBookmarkButton(4);
+      while (button->visible()) {
+        bb_view_pref_.set_width(bb_view_pref_.width() - 25);
+        bb_view_->SetBounds(0, 0, bb_view_pref_.width(),
+                            bb_view_pref_.height());
+        bb_view_->Layout();
+      }
+    } else {
+      int width = 700;
+      test_for_menu_exit_view_ = new TestForMenuExitView;
+      test_for_menu_exit_view_->SetBounds(width - 30, 4, 20, 20);
+      bb_view_->AddChildView(test_for_menu_exit_view_);
+      bb_view_pref_ = bb_view_->GetPreferredSize();
+      bb_view_pref_.set_width(width);
+      bb_view_->SetBounds(0, 0, bb_view_pref_.width(),
+                          bb_view_pref_.height());
       bb_view_->Layout();
     }
 
     tmp_parent.RemoveChildView(bb_view_.get());
 
     views::ViewsDelegate::views_delegate = &views_delegate_;
     ViewEventTestBase::SetUp();
   }
 
   virtual void TearDown() {
@@ skipping 23 matching lines @@
   views::TextButton* GetBookmarkButton(int view_index) {
     return bb_view_->GetBookmarkButton(view_index);
   }
 
   // See comment above class description for what this does.
   virtual bool CreateBigMenu() { return false; }
 
   BookmarkModel* model_;
   scoped_ptr<BookmarkBarView> bb_view_;
   TestingPageNavigator navigator_;
+  bool test_for_menu_exit_flag_;
+  TestForMenuExitView* test_for_menu_exit_view_;
 
  private:
   void AddTestData(bool big_menu) {
     const BookmarkNode* bb_node = model_->bookmark_bar_node();
     std::string test_base = "file:///c:/tmp/";
     const BookmarkNode* f1 = model_->AddFolder(bb_node, 0, ASCIIToUTF16("F1"));
     model_->AddURL(f1, 0, ASCIIToUTF16("f1a"), GURL(test_base + "f1a"));
     const BookmarkNode* f11 = model_->AddFolder(f1, 1, ASCIIToUTF16("F11"));
     model_->AddURL(f11, 0, ASCIIToUTF16("f11a"), GURL(test_base + "f11a"));
     if (big_menu) {
@@ skipping 1372 matching lines @@
     ASSERT_TRUE(menu != NULL);
     ASSERT_TRUE(menu->GetSubmenu()->IsShowing());
 
     menu->GetMenuController()->CancelAll();
 
     Done();
   }
 };
 
 VIEW_TEST(BookmarkBarViewTest19, BookmarkBarViewTest19_SiblingMenu)
+
+#if defined(USE_ASH) && defined(USE_X11)

[sky, 2013/01/30 14:53:04]

Are you sure this is needed?

[sschmitz, 2013/01/30 20:43:58]

I removed it. git try will tell us the answer;)
Done

+
+// Verify that when clicking a mouse button outside a context menu,
+// the context menu is dismissed *and* the underlying view receives
+// the the mouse event (due to event reposting).
+class BookmarkBarViewTest20 : public BookmarkBarViewEventTestBase {
+ public:
+  BookmarkBarViewTest20() : BookmarkBarViewEventTestBase(true) {}
+
+ protected:
+  virtual void DoTestOnMessageLoop() {
+    ASSERT_TRUE(test_for_menu_exit_view_ != NULL);
+    ASSERT_TRUE(test_for_menu_exit_view_->press_count() == 0);
+
+    // Move the mouse to the Test View and press the left mouse button.
+    ui_test_utils::MoveMouseToCenterAndPress(
+        test_for_menu_exit_view_, ui_controls::LEFT,
+        ui_controls::DOWN | ui_controls::UP,
+        CreateEventTask(this, &BookmarkBarViewTest20::Step1));
+  }
+
+ private:
+  void Step1() {
+    ASSERT_TRUE(test_for_menu_exit_view_->press_count() == 1);
+    ASSERT_TRUE(bb_view_->GetMenu() == NULL);
+
+    // Move the mouse to the first folder on the bookmark bar and press the
+    // left mouse button.
+    views::TextButton* button = GetBookmarkButton(0);
+    ui_test_utils::MoveMouseToCenterAndPress(
+        button, ui_controls::LEFT, ui_controls::DOWN | ui_controls::UP,
+        CreateEventTask(this, &BookmarkBarViewTest20::Step2));
+  }
+
+  void Step2() {
+    ASSERT_TRUE(test_for_menu_exit_view_->press_count() == 1);
+    views::MenuItemView* menu = bb_view_->GetMenu();
+    ASSERT_TRUE(menu != NULL);
+    ASSERT_TRUE(menu->GetSubmenu()->IsShowing());
+
+    // Move the mouse to the Test View and press the left mouse button.
+    // The context menu will consume the event and exit. Thereafter,
+    // the event is reposted and delivered to the Test View which
+    // increases its press-count.
+    ui_test_utils::MoveMouseToCenterAndPress(
+        test_for_menu_exit_view_, ui_controls::LEFT,
+        ui_controls::DOWN | ui_controls::UP,
+        CreateEventTask(this, &BookmarkBarViewTest20::Step3));
+  }
+
+  void Step3() {
+    ASSERT_TRUE(test_for_menu_exit_view_->press_count() == 2);
+    ASSERT_TRUE(bb_view_->GetMenu() == NULL);
+    Done();
+  }
+
+};
+
+VIEW_TEST(BookmarkBarViewTest20, ContextMenuExitTest)
+
+#endif