Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: Source/WebCore/bindings/v8/ScriptFunctionCall.cpp

Issue 12087054: Revert 140611 (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1397/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/WebCore/bindings/v8/ScriptDebugServer.cpp ('k') | Source/WebCore/bindings/v8/ScriptProfiler.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebCore/bindings/v8/ScriptFunctionCall.cpp
===================================================================
--- Source/WebCore/bindings/v8/ScriptFunctionCall.cpp (revision 141118)
+++ Source/WebCore/bindings/v8/ScriptFunctionCall.cpp (working copy)
@@ -62,13 +62,13 @@
void ScriptCallArgumentHandler::appendArgument(const String& argument)
{
ScriptScope scope(m_scriptState);
- m_arguments.append(v8String(argument, m_scriptState->isolate()));
+ m_arguments.append(deprecatedV8String(argument));
}
void ScriptCallArgumentHandler::appendArgument(const char* argument)
{
ScriptScope scope(m_scriptState);
- m_arguments.append(v8String(argument, m_scriptState->isolate()));
+ m_arguments.append(deprecatedV8String(argument));
}
void ScriptCallArgumentHandler::appendArgument(long argument)
@@ -118,7 +118,7 @@
ScriptScope scope(m_scriptState, reportExceptions);
v8::Local<v8::Object> thisObject = m_thisObject.v8Object();
- v8::Local<v8::Value> value = thisObject->Get(v8String(m_name, m_scriptState->isolate()));
+ v8::Local<v8::Value> value = thisObject->Get(deprecatedV8String(m_name));
if (!scope.success()) {
hadException = true;
return ScriptValue();
@@ -155,7 +155,7 @@
ScriptScope scope(m_scriptState, reportExceptions);
v8::Local<v8::Object> thisObject = m_thisObject.v8Object();
- v8::Local<v8::Value> value = thisObject->Get(v8String(m_name, m_scriptState->isolate()));
+ v8::Local<v8::Value> value = thisObject->Get(deprecatedV8String(m_name));
if (!scope.success()) {
hadException = true;
return ScriptObject();
« no previous file with comments | « Source/WebCore/bindings/v8/ScriptDebugServer.cpp ('k') | Source/WebCore/bindings/v8/ScriptProfiler.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698