Source/WebCore/bindings/v8/ScriptController.cpp - Issue 12087054: Revert 140611

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebCore/bindings/v8/ScriptController.cpp

Issue 12087054: Revert 140611 (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1397/

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/WebCore/bindings/v8/ScriptController.cpp

===================================================================

--- Source/WebCore/bindings/v8/ScriptController.cpp (revision 141118)

+++ Source/WebCore/bindings/v8/ScriptController.cpp (working copy)

@@ -492,7 +492,7 @@

// Attach to the global object.

v8::Handle<v8::Object> global = v8Context->Global();

- global->Set(v8String(key, v8Context->GetIsolate()), value);

+ global->Set(deprecatedV8String(key), value);

}

bool ScriptController::haveInterpreter() const

@@ -515,7 +515,7 @@

v8::HandleScope handleScope;

v8::Handle<v8::Context> v8Context = m_windowShell->context();

v8Context->AllowCodeGenerationFromStrings(false);

- v8Context->SetErrorMessageForCodeGenerationFromStrings(v8String(errorMessage, v8Context->GetIsolate()));

+ v8Context->SetErrorMessageForCodeGenerationFromStrings(deprecatedV8String(errorMessage));

}

PassScriptInstance ScriptController::createScriptInstanceForWidget(Widget* widget)