Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 12087048: Merge 140927 (Closed)

Created:
7 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 10 months ago
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1364/
Visibility:
Public.

Description

Merge 140927 > Check notification permissions in the show() method > https://bugs.webkit.org/show_bug.cgi?id=108009 > > Reviewed by Adam Barth. > > Source/WebCore: > > Tests: fast/notifications/notifications-constructor-with-permission.html > fast/notifications/notifications-constructor-without-permission.html > > * Modules/notifications/Notification.cpp: > (WebCore::Notification::show): > (WebCore::Notification::taskTimerFired): > > LayoutTests: > > * fast/notifications/notifications-constructor-with-permission-expected.txt: Added. > * fast/notifications/notifications-constructor-with-permission.html: Added. > * fast/notifications/notifications-constructor-without-permission-expected.txt: Added. > * fast/notifications/notifications-constructor-without-permission.html: Added. > TBR=jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141072

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
A + LayoutTests/fast/notifications/notifications-constructor-with-permission.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/notifications/notifications-constructor-with-permission-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/notifications/notifications-constructor-without-permission.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/notifications/notifications-constructor-without-permission-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/Modules/notifications/Notification.cpp View 2 chunks +13 lines, -8 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jochen (gone - plz use gerrit)
7 years, 10 months ago (2013-01-29 08:21:37 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698