Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 12087023: Make asan=1 GYP flag enforce -gline-tables-only. (Closed)

Created:
7 years, 10 months ago by Alexander Potapenko
Modified:
7 years, 10 months ago
Reviewers:
glotov, Nico
CC:
chromium-reviews, inferno, glotov
Visibility:
Public.

Description

Make asan=1 GYP flag enforce -gline-tables-only. Having at least this level of debug info is a must in order to have line numbers in the symbolized ASan reports. On the other hand the binaries will be smaller than those built with -g, so we'll be able to copy the binaries between bots. Users of asan_symbolize.py will need to set LLVM_SYMBOLIZER_PATH in order to have full function names with -gline-tables-only (see http://dev.chromium.org/developers/testing/addresssanitizer) BUG=128544 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179326

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/common.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Alexander Potapenko
Nico, PTAL Abhishek, Denis, FYI.
7 years, 10 months ago (2013-01-28 14:02:19 UTC) #1
Nico
lgtm
7 years, 10 months ago (2013-01-28 21:43:44 UTC) #2
glotov
7 years, 10 months ago (2013-01-29 09:03:36 UTC) #3
lgtm

lgtm

Powered by Google App Engine
This is Rietveld 408576698