Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 1208683002: cc: Associate scheduled tasks with a prepare tiles call. (Closed)

Created:
5 years, 6 months ago by vmpstr
Modified:
5 years, 6 months ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org, yuhaoz
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Associate scheduled tasks with a prepare tiles call. This patch adds a count of prepare tiles. As well, any task that is created as a result of a prepare tiles gets the number of that prepare tiles. This can be used to determine which tasks came from which prepare tiles. Note that a further prepare tiles that would reuse a task does not modify the id. That is the id still refers to the prepare tile that created the task. R=danakj CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/9da577a9c2b932e36e2ec22e473d7458ba3fe97b Cr-Commit-Position: refs/heads/master@{#336070}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -9 lines) Patch
M cc/tiles/tile_manager.h View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/tiles/tile_manager.cc View 10 chunks +20 lines, -9 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
vmpstr
Please take a look.
5 years, 6 months ago (2015-06-24 22:03:57 UTC) #1
danakj
> tiles. This can be used to allocate which tasks came from which prepare s/allocate/determine/ ...
5 years, 6 months ago (2015-06-24 22:06:19 UTC) #2
danakj
LGTM
5 years, 6 months ago (2015-06-24 22:06:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1208683002/1
5 years, 6 months ago (2015-06-24 22:12:41 UTC) #7
commit-bot: I haz the power
Exceeded global retry quota
5 years, 6 months ago (2015-06-24 22:31:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1208683002/1
5 years, 6 months ago (2015-06-24 22:34:53 UTC) #11
commit-bot: I haz the power
Exceeded global retry quota
5 years, 6 months ago (2015-06-24 22:46:32 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1208683002/1
5 years, 6 months ago (2015-06-25 00:06:31 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-25 02:11:17 UTC) #16
commit-bot: I haz the power
5 years, 6 months ago (2015-06-25 02:12:14 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9da577a9c2b932e36e2ec22e473d7458ba3fe97b
Cr-Commit-Position: refs/heads/master@{#336070}

Powered by Google App Engine
This is Rietveld 408576698