Issue 1208673003: Subzero: Fix cmake build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1208673003: Subzero: Fix cmake build. (Closed)

Created:
5 years, 6 months ago by Jim Stichnoth

Modified:
5 years, 6 months ago

Reviewers:
jvoung (off chromium), Karl, JF, John

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Subzero: Fix cmake build. Also fixes a set of warnings that only show up for the cmake build. BUG= none R=jpp@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=19376c6e3ac2efde11477ab70b6cab0010f8d069

Patch Set 2 : Use default #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	CMakeLists.txt	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	src/IceOperand.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

John

lgtm https://codereview.chromium.org/1208673003/diff/1/src/IceOperand.h File src/IceOperand.h (right): https://codereview.chromium.org/1208673003/diff/1/src/IceOperand.h#newcode84 src/IceOperand.h:84: virtual ~Operand() {} = default?

5 years, 6 months ago (2015-06-25 00:28:55 UTC) #3

Jim Stichnoth

Committed patchset #2 (id:20001) manually as 19376c6e3ac2efde11477ab70b6cab0010f8d069 (presubmit successful).

5 years, 6 months ago (2015-06-25 00:52:56 UTC) #4

Jim Stichnoth

5 years, 6 months ago (2015-06-25 00:53:56 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/1208673003/diff/1/src/IceOperand.h
File src/IceOperand.h (right):

https://codereview.chromium.org/1208673003/diff/1/src/IceOperand.h#newcode84
src/IceOperand.h:84: virtual ~Operand() {}
On 2015/06/25 00:28:55, John wrote:
> = default?

Done.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 1208673003: Subzero: Fix cmake build. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Use default #

Messages