Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1587)

Issue 120863003: Convert ExtensionRegistry to a BrowserContextKeyedService (Closed)

Created:
6 years, 12 months ago by James Cook
Modified:
6 years, 12 months ago
Reviewers:
miket_OOO
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Convert ExtensionRegistry to a BrowserContextKeyedService This removes dependencies on ExtensionService, which does not exist for app_shell. * Convert all of src/extensions to use ExtensionRegistry's extension sets. * Remove ExtensionService::blacklisted_extensions() and convert all callers to use ExtensionRegistry. BUG=none TEST=existing unit_tests, browser_tests R=miket@chromium.org TBR=phajden.jr@chromium.org for adding dependency on components/browser_context_keyed_service Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242624

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+227 lines, -97 lines) Patch
M chrome/browser/extensions/extension_service.h View 2 chunks +5 lines, -3 lines 2 comments Download
M chrome/browser/extensions/extension_service.cc View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 10 chunks +72 lines, -59 lines 0 comments Download
M chrome/browser/extensions/extension_system_factory.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M extensions/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/event_router.cc View 4 chunks +9 lines, -8 lines 0 comments Download
M extensions/browser/extension_registry.h View 2 chunks +16 lines, -4 lines 0 comments Download
M extensions/browser/extension_registry.cc View 2 chunks +12 lines, -0 lines 0 comments Download
A extensions/browser/extension_registry_factory.h View 1 chunk +43 lines, -0 lines 0 comments Download
A extensions/browser/extension_registry_factory.cc View 1 chunk +47 lines, -0 lines 0 comments Download
M extensions/browser/lazy_background_task_queue.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M extensions/browser/process_manager.cc View 4 chunks +13 lines, -13 lines 0 comments Download
M extensions/extensions.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
James Cook
Ben, PTAL. This is the BCKS conversion we talked about last week. Once this lands ...
6 years, 12 months ago (2013-12-27 01:00:27 UTC) #1
James Cook
miket, can you take a look? I'm blocked on this patch landing.
6 years, 12 months ago (2013-12-27 17:07:21 UTC) #2
miket_OOO
lgtm
6 years, 12 months ago (2013-12-27 17:12:23 UTC) #3
James Cook
6 years, 12 months ago (2013-12-27 17:44:05 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r242624 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698