Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(90)

Issue 12086096: Merge 141019 (Closed)

Created:
8 years, 1 month ago by kerz_chromium
Modified:
8 years, 1 month ago
Reviewers:
commit-queue
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1364/
Visibility:
Public.

Description

Merge 141019 > [Chromium, Mobile] Do not show disambiguation pop up in mobile sites > https://bugs.webkit.org/show_bug.cgi?id=107607 > > Patch by Dan Alcantara <dfalcantara@chromium.org>; on 2013-01-28 > Reviewed by Adam Barth. > > Add a check before showing the disambiguation popup to prevent it from appearing > on mobile sites. Makes a similar test to the current disambiguation popup test > that expects the popup to never appear. > > * src/WebViewImpl.cpp: > (WebKit::WebViewImpl::handleGestureEvent): > (WebKit): > (WebKit::WebViewImpl::isLikelyMobileSite): > * src/WebViewImpl.h: > (WebViewImpl): > * tests/WebFrameTest.cpp: > * tests/data/disambiguation_popup_mobile_site.html: Added. > > * src/WebViewImpl.cpp: > (WebKit::WebViewImpl::handleGestureEvent): > (WebKit): > (WebKit::WebViewImpl::shouldDisableDesktopWorkarounds): > * src/WebViewImpl.h: > (WebViewImpl): > * tests/WebFrameTest.cpp: > * tests/data/disambiguation_popup_mobile_site.html: Added. TBR=commit-queue@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141475

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -1 line) Patch
M Source/WebKit/chromium/ChangeLog View 1 chunk +30 lines, -1 line 0 comments Download
M Source/WebKit/chromium/src/WebViewImpl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/src/WebViewImpl.cpp View 2 chunks +10 lines, -1 line 0 comments Download
M Source/WebKit/chromium/tests/WebFrameTest.cpp View 1 chunk +33 lines, -0 lines 0 comments Download
A + Source/WebKit/chromium/tests/data/disambiguation_popup_mobile_site.html View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
kerz_chromium
8 years, 1 month ago (2013-01-31 21:22:46 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698