Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: content/public/browser/web_contents.h

Issue 12086095: Fixed drag and drop into and out of Browser Plugin. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Addressed Comments Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/web_contents.h
diff --git a/content/public/browser/web_contents.h b/content/public/browser/web_contents.h
index c38df686ace6fd3d7fdfb954ebdc491af4776fc2..e5d713127e73e9deb1bae1d9ee8150699a3e9f7d 100644
--- a/content/public/browser/web_contents.h
+++ b/content/public/browser/web_contents.h
@@ -17,6 +17,7 @@
#include "content/public/browser/web_ui.h"
#include "ipc/ipc_sender.h"
#include "third_party/skia/include/core/SkColor.h"
+#include "third_party/WebKit/Source/WebKit/chromium/public/WebDragOperation.h"
#include "ui/base/window_open_disposition.h"
#include "ui/gfx/native_widget_types.h"
#include "ui/gfx/size.h"
@@ -343,8 +344,18 @@ class WebContents : public PageNavigator,
// times, subsequent calls are ignored.
virtual void OnCloseStarted() = 0;
- // A render view-originated drag has ended. Informs the render view host and
- // WebContentsDelegate.
+ // Informs the render view host and the BrowserPluginEmbedder, if present, of
+ // a Drag Source End.
+ virtual void DragSourceEndedAt(int client_x, int client_y, int screen_x,
Fady Samuel 2013/04/18 18:22:56 Is this necessary?
mthiesse 2013/04/18 18:36:32 Done.
+ int screen_y, WebKit::WebDragOperation operation) = 0;
+
+ // Informs the render view host and the BrowserPluginEmbedder, if present, of
+ // a Drag Source Move.
+ virtual void DragSourceMovedTo(int client_x, int client_y,
Fady Samuel 2013/04/18 18:22:56 Is this necessary?
mthiesse 2013/04/18 18:36:32 Done.
+ int screen_x, int screen_y) = 0;
+
+ // A render view-originated drag has ended. Informs the render view host, the
+ // WebContentsDelegate, and the BrowserPluginEmbedder, if present.
Fady Samuel 2013/04/18 18:22:56 Please avoid referencing BrowserPluginEmbedder her
mthiesse 2013/04/18 18:36:32 It's probably fine if I leave this comment as-is.
virtual void SystemDragEnded() = 0;
// Notification the user has made a gesture while focus was on the

Powered by Google App Engine
This is Rietveld 408576698