content/common/drag_messages.h - Issue 12086095: Fixed drag and drop into and out of Browser Plugin.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/common/drag_messages.h

Issue 12086095: Fixed drag and drop into and out of Browser Plugin. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Re-disabled when command line flag not present. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/browser/browser_plugin/browser_plugin_guest.cc ('K') | « content/browser/web_contents/web_contents_view_guest.cc ('k') | content/renderer/browser_plugin/browser_plugin.cc » ('j') | content/renderer/render_view_impl.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // IPC messages for drag and drop.	5 // IPC messages for drag and drop.

6 // Multiply-included message file, hence no include guard.	6 // Multiply-included message file, hence no include guard.

7	7

8 #include "content/common/drag_event_source_info.h"	8 #include "content/common/drag_event_source_info.h"

9 #include "content/public/common/common_param_traits.h"	9 #include "content/public/common/common_param_traits.h"

10 #include "ipc/ipc_message_macros.h"	10 #include "ipc/ipc_message_macros.h"

(...skipping 51 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
62 gfx::Vector2d /* image_offset */,	62 gfx::Vector2d /* image_offset */,

63 content::DragEventSourceInfo /* event_info */)	63 content::DragEventSourceInfo /* event_info */)

64	64

65 // The page wants to update the mouse cursor during a drag & drop operation.	65 // The page wants to update the mouse cursor during a drag & drop operation.

66 // \|is_drop_target\| is true if the mouse is over a valid drop target.	66 // \|is_drop_target\| is true if the mouse is over a valid drop target.

67 IPC_MESSAGE_ROUTED1(DragHostMsg_UpdateDragCursor,	67 IPC_MESSAGE_ROUTED1(DragHostMsg_UpdateDragCursor,

68 WebKit::WebDragOperation /* drag_operation */)	68 WebKit::WebDragOperation /* drag_operation */)

69	69

70 // Notifies the host that the renderer finished a drop operation.	70 // Notifies the host that the renderer finished a drop operation.

71 IPC_MESSAGE_ROUTED0(DragHostMsg_TargetDrop_ACK)	71 IPC_MESSAGE_ROUTED0(DragHostMsg_TargetDrop_ACK)

	72

	73 // Notifies the host that the drag operation has stopped.

	74 IPC_MESSAGE_ROUTED0(DragHostMsg_DragStopped)
	Fady Samuel 2013/02/01 14:59:28 Why do we need to introduce a new message? Why do we need to introduce a new message? mthiesse 2013/02/01 15:43:54 We need a message that can be sent to the embedder Show quoted text On 2013/02/01 14:59:28, Fady Samuel wrote: > Why do we need to introduce a new message? We need a message that can be sent to the embedder to let it know that the drag operation is done, so that it can inform the guest of the same, so that the guest can finish up its drag event and restore user input.
OLD	NEW