Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: chrome/browser/ui/webui/sync_promo/sync_promo_trial.cc

Issue 12086069: Enable Chrome Signin from Webstore (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/sync_promo/sync_promo_trial.cc
diff --git a/chrome/browser/ui/webui/sync_promo/sync_promo_trial.cc b/chrome/browser/ui/webui/sync_promo/sync_promo_trial.cc
index 819b38b80a7363501c5c381677620b2752cf35c9..57d0301ffee722007336dd3b33dc224cbb2f09d6 100644
--- a/chrome/browser/ui/webui/sync_promo/sync_promo_trial.cc
+++ b/chrome/browser/ui/webui/sync_promo/sync_promo_trial.cc
@@ -25,6 +25,8 @@ enum {
UMA_EXTENSION_INSTALL_BUBBLE_SIGNED_IN,
UMA_UNKNOWN_SHOWN,
UMA_UNKNOWN_SIGNED_IN,
+ UMA_WEBSTORE_INSTALL_SHOWN,
+ UMA_WEBSTORE_INSTALL_SIGNED_IN,
UMA_MAX,
};
@@ -52,6 +54,9 @@ void RecordUserShownPromo(content::WebUI* web_ui) {
case SyncPromoUI::SOURCE_EXTENSION_INSTALL_BUBBLE:
uma = UMA_EXTENSION_INSTALL_BUBBLE_SHOWN;
break;
+ case SyncPromoUI::SOURCE_WEBSTORE_INSTALL:
+ uma = UMA_WEBSTORE_INSTALL_SHOWN;
+ break;
case SyncPromoUI::SOURCE_UNKNOWN:
uma = UMA_UNKNOWN_SHOWN;
break;
@@ -59,7 +64,7 @@ void RecordUserShownPromo(content::WebUI* web_ui) {
// If this assert hits, then the SyncPromoUI::Source enum has changed and
// the UMA enum above, this switch statement and histograms.xml all need
// to be updated to reflect that.
- COMPILE_ASSERT(SyncPromoUI::SOURCE_UNKNOWN == 5,
+ COMPILE_ASSERT(SyncPromoUI::SOURCE_UNKNOWN == 6,
kSourceEnumHasChangedButNotThisSwitchStatement);
NOTREACHED();
break;
@@ -90,9 +95,12 @@ void RecordUserSignedIn(content::WebUI* web_ui) {
case SyncPromoUI::SOURCE_UNKNOWN:
uma = UMA_UNKNOWN_SIGNED_IN;
break;
+ case SyncPromoUI::SOURCE_WEBSTORE_INSTALL:
+ uma = UMA_WEBSTORE_INSTALL_SIGNED_IN;
+ break;
default:
// This switch statement needs to be updated when the enum Source changes.
- COMPILE_ASSERT(SyncPromoUI::SOURCE_UNKNOWN == 5,
+ COMPILE_ASSERT(SyncPromoUI::SOURCE_UNKNOWN == 6,
kSourceEnumHasChangedButNotThisSwitchStatement);
NOTREACHED();
break;

Powered by Google App Engine
This is Rietveld 408576698