Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: tools/dom/templates/html/impl/impl_Element.darttemplate

Issue 12086062: Rename mappedBy to map. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/dom/templates/html/impl/impl_Element.darttemplate
diff --git a/tools/dom/templates/html/impl/impl_Element.darttemplate b/tools/dom/templates/html/impl/impl_Element.darttemplate
index 752c93f479f557f2798e39357ca98b4c2736471e..0f842c2802d4aa18855bc4f69c5806442457dfd3 100644
--- a/tools/dom/templates/html/impl/impl_Element.darttemplate
+++ b/tools/dom/templates/html/impl/impl_Element.darttemplate
@@ -61,10 +61,12 @@ class _ChildrenElementList implements List {
return IterableMixinWorkaround.joinList(this, separator);
}
- List mappedBy(f(Element element)) {
+ Iterable map(f(Element element)) {
floitsch 2013/01/30 14:48:44 should return an Iterable.
Lasse Reichstein Nielsen 2013/01/31 11:33:49 Done.
return IterableMixinWorkaround.mappedByList(this, f);
}
+ Iterable mappedBy(f(ELement element)) => map(f);
+
Iterable<Element> where(bool f(Element element)) {
return IterableMixinWorkaround.where(this, f);
}
@@ -73,7 +75,7 @@ class _ChildrenElementList implements List {
return _element.$dom_firstElementChild == null;
}
- List<Element> take(int n) {
+ Iterable<Element> take(int n) {
return IterableMixinWorkaround.takeList(this, n);
}
@@ -81,7 +83,7 @@ class _ChildrenElementList implements List {
return IterableMixinWorkaround.takeWhile(this, test);
}
- List<Element> skip(int n) {
+ Iterable<Element> skip(int n) {
return IterableMixinWorkaround.skipList(this, n);
}
@@ -274,10 +276,12 @@ class _FrozenElementList implements List {
return IterableMixinWorkaround.joinList(this, separator);
}
- List mappedBy(f(Element element)) {
+ Iterable map(f(Element element)) {
floitsch 2013/01/30 14:48:44 should return an Iterable.
Lasse Reichstein Nielsen 2013/01/31 11:33:49 Done.
return IterableMixinWorkaround.mappedByList(this, f);
}
+ Iterable mappedBy(f(ELement element)) => map(f);
+
Iterable<Element> where(bool f(Element element)) {
return IterableMixinWorkaround.where(this, f);
}
@@ -303,7 +307,7 @@ class _FrozenElementList implements List {
List<Element> toList() => new List<Element>.from(this);
Set<Element> toSet() => new Set<Element>.from(this);
- List<Element> take(int n) {
+ Iterable<Element> take(int n) {
return IterableMixinWorkaround.takeList(this, n);
}
@@ -311,7 +315,7 @@ class _FrozenElementList implements List {
return IterableMixinWorkaround.takeWhile(this, test);
}
- List<Element> skip(int n) {
+ Iterable<Element> skip(int n) {
return IterableMixinWorkaround.skipList(this, n);
}

Powered by Google App Engine
This is Rietveld 408576698