Issue 12086059: Add interactive_ui_tests_run.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12086059: Add interactive_ui_tests_run. (Closed)

Created:
7 years, 10 months ago by M-A Ruel

Modified:
7 years, 8 months ago

Reviewers:
csharp

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add interactive_ui_tests_run. Add the required target and the .isolate file covering most test cases on linux, mac and windows. R=csharp@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194412

Patch Set 1 : traced on linux, mac and windows #

Total comments: 3

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+121 lines, -0 lines)			Patch
M	build/all.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+21 lines, -0 lines	0 comments	Download
A	chrome/interactive_ui_tests.isolate	View	1 chunk	+99 lines, -0 lines	3 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

https://codereview.chromium.org/12086059/diff/10001/chrome/interactive_ui_tests.isolate File chrome/interactive_ui_tests.isolate (right): https://codereview.chromium.org/12086059/diff/10001/chrome/interactive_ui_tests.isolate#newcode46 chrome/interactive_ui_tests.isolate:46: 'test/data/', This is way too much data for what ...

7 years, 8 months ago (2013-04-16 18:07:57 UTC) #1

csharp

lgtm https://codereview.chromium.org/12086059/diff/10001/chrome/interactive_ui_tests.isolate File chrome/interactive_ui_tests.isolate (right): https://codereview.chromium.org/12086059/diff/10001/chrome/interactive_ui_tests.isolate#newcode94 chrome/interactive_ui_tests.isolate:94: '../third_party/python_26/', On 2013/04/16 18:07:57, Marc-Antoine Ruel wrote: > ...

7 years, 8 months ago (2013-04-16 18:21:14 UTC) #2

M-A Ruel

7 years, 8 months ago (2013-04-16 19:19:14 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r194412 (presubmit successful).

Expand Messages | Collapse Messages