DescriptionMerge 140803
> INPUT_MULTIPLE_FIELDS_UI: Inconsistent value of aria-valuetext attribute
> https://bugs.webkit.org/show_bug.cgi?id=107897
>
> Reviewed by Kentaro Hara.
>
> Source/WebCore:
>
> aria-valuetext and aria-valuenow attributes had inconsistent values in
> a case of initial empty state and a case that a user clears a field.
>
> - aria-valuetext attribute should have "blank" message in the initial
> empty state.
> - aria-valuenow attribute should be removed in the cleared empty state.
>
> Also, we have a bug that aira-valuenow had a symbolic value such as "AM"
> "January". It should always have a numeric value according to the
> specification.
> http://www.w3.org/TR/wai-aria/states_and_properties#aria-valuenow
>
> No new tests. Updates fast/forms/*-multiple-fields/*-multiple-fields-ax-aria-attributes.html.
>
> * html/shadow/DateTimeFieldElement.cpp:
> (WebCore::DateTimeFieldElement::DateTimeFieldElement):
> Set "blank" message to aria-valuetext attribute.
> (WebCore::DateTimeFieldElement::updateVisibleValue):
> aria-valuenow attribute should be a numeric value. Apply String::number
> to the return value of valueForARIAValueNow.
> Remove aria-valuenow attribute if nothing is selected.
> (WebCore::DateTimeFieldElement::valueForARIAValueNow):
> Added.
> * html/shadow/DateTimeFieldElement.h:
> (DateTimeFieldElement): Declare valueForARIAValueNow.
>
> * html/shadow/DateTimeSymbolicFieldElement.cpp:
> (WebCore::DateTimeSymbolicFieldElement::valueForARIAValueNow):
> Added. Returns 1 + internal selection index.
> For example, the function returns 1 for January.
> * html/shadow/DateTimeSymbolicFieldElement.h:
> (DateTimeSymbolicFieldElement): Declare valueForARIAValueNow.
>
> LayoutTests:
>
> Fix existing tests to show aria-valuenow attribute values.
>
> * fast/forms/resources/multiple-fields-ax-aria-attributes.js: Added.
> * fast/forms/date-multiple-fields/date-multiple-fields-ax-aria-attributes-expected.txt:
> * fast/forms/date-multiple-fields/date-multiple-fields-ax-aria-attributes.html:
> Use multiple-fields-ax-aria-attributes.js.
> Add tests for initial empty-value state.
> * fast/forms/month-multiple-fields/month-multiple-fields-ax-aria-attributes-expected.txt:
> * fast/forms/month-multiple-fields/month-multiple-fields-ax-aria-attributes.html:
> Use multiple-fields-ax-aria-attributes.js.
> * fast/forms/time-multiple-fields/time-multiple-fields-ax-aria-attributes-expected.txt:
> * fast/forms/time-multiple-fields/time-multiple-fields-ax-aria-attributes.html:
> Use multiple-fields-ax-aria-attributes.js.
>
TBR=tkent@chromium.org
BUG=crbug.com/172199
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141201
Patch Set 1 #Messages
Total messages: 1 (0 generated)
|