Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 12086048: Bugfix in test_runner: in certain cases tests did not get rerun (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index 95a0532d08d5cf861cb23519317a3c28f8fc4498..54800d2fd9122e80096349834fe3db42bbdf60a3 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -1724,8 +1724,15 @@ class ProcessQueue {
var runningProcess = new RunningProcess(testCase, command);
runningProcess.start().then((CommandOutput commandOutput) {
if (isLastCommand) {
+ // NOTE: We need to call commandOutput.unexpectedOutput here.
+ // Calling this getter may result in the side-effect, that
+ // commandOutput.requestRetry is set to true.
+ // (BrowserCommandOutputImpl._failedBecauseOfMissingXDisplay
+ // does that for example)
+ // TODO(ricow/kustermann): Issue 8206
+ var unexpectedOutput = commandOutput.unexpectedOutput;
if (allowRetry && testCase.usesWebDriver
- && commandOutput.unexpectedOutput
+ && unexpectedOutput
&& (testCase as BrowserTestCase).numRetries > 0) {
// Selenium tests can be flaky. Try rerunning.
commandOutput.requestRetry = true;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698