Bugfix in test_runner: in certain cases tests did not get rerun

tools/testing/dart/test_runner.dart

Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index 95a0532d08d5cf861cb23519317a3c28f8fc4498..59b2f8aca279cd0b83ab365f6f56814433c6d736 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -1724,8 +1724,16 @@ class ProcessQueue {
       var runningProcess = new RunningProcess(testCase, command);
       runningProcess.start().then((CommandOutput commandOutput) {
         if (isLastCommand) {
+          // NOTE: We need to call commandOutput.unexpectedOutput here.
+          // Calling this getter may result in the side-effect, that
+          // commandOutput.requestRetry is set to true.
+          // (BrowserCommandOutputImpl._failedBecauseOfMissingXDisplay
+          // does that for example)
+          // TODO(ricow/kustermann): Getters should not have any

[ricow1, 2013/01/29 19:58:33]

I would even file a bug for this

[kustermann, 2013/01/30 09:04:42]

Done.

+          // side-effects -- this should be fixed.
+          var unexpectedOutput = commandOutput.unexpectedOutput;
           if (allowRetry && testCase.usesWebDriver
-              && commandOutput.unexpectedOutput
+              && unexpectedOutput
               && (testCase as BrowserTestCase).numRetries > 0) {
             // Selenium tests can be flaky. Try rerunning.
             commandOutput.requestRetry = true;