content: implement unittests backend for Ozone GBM

ui/ozone/public/ozone_gpu_test_helper.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/ozone/public/ozone_gpu_test_helper.h"
 
+#include "base/run_loop.h"
 #include "base/thread_task_runner_handle.h"
 #include "ipc/ipc_listener.h"
 #include "ipc/ipc_message.h"
 #include "ipc/ipc_sender.h"
 #include "ipc/message_filter.h"
 #include "ui/ozone/public/gpu_platform_support.h"
 #include "ui/ozone/public/gpu_platform_support_host.h"
 #include "ui/ozone/public/ozone_platform.h"
 
 namespace ui {
@@ skipping 107 matching lines @@
                             base::Unretained(fake_gpu_process_.get())));
   fake_gpu_process_->Init();
 
   fake_gpu_process_host_.reset(new FakeGpuProcessHost(
       gpu_task_runner, io_helper_thread_->task_runner()));
   fake_gpu_process_host_->Init();
 
   return true;
 }
 
+// static
+scoped_ptr<OzoneInitializerForTest> OzoneInitializerForTest::Create() {
+  scoped_ptr<OzoneInitializerForTest> self(new OzoneInitializerForTest());
+  if (!self->Initialize())
+    return nullptr;
+  return self.Pass();
+}
+
+OzoneInitializerForTest::OzoneInitializerForTest() {}
+
+OzoneInitializerForTest::~OzoneInitializerForTest() {}
+
+bool OzoneInitializerForTest::Initialize() {
+  // On Ozone, the backend initializes the event system using a UI thread.
+  message_loop_.reset(new base::MessageLoopForUI);

[spang, 2015/12/02 17:00:03]

This is a library component. I'm very unconvinced about creating a message loop
for the main thread here. The main thread message loop is the main program's
problem, so it belongs in either the test or test harness.

[dshwang, 2015/12/08 01:12:38]

There are pros and cons.

If the loop should belong to test harness, gl_image_test_support and
content_test_suite needs additional ozone specific code.

// time to initialize
#if defined(USE_OZONE)
message_loop_.reset(new base::MessageLoopForUI);
#endif

// time to destory
#if defined(USE_OZONE)
message_loop_.reset();
#endif

Worth to note is that all code also creates OzoneInitializerForTest at the time.
So it's not bad that OzoneInitializerForTest creates the loop by itself.

[dshwang, 2015/12/08 22:19:33]

At least, gl_image_test_support and content_test_suite don't need message_loop
so they don't create it.

Do you want to create message loop for all platforms, although only ozone really
requires it?

+
+  OzonePlatform::InitializeForUI();
+  OzonePlatform::InitializeForGPU();
+  gpu_helper_.reset(new OzoneGpuTestHelper);
+  if (!gpu_helper_->Initialize(base::ThreadTaskRunnerHandle::Get(),
+                               base::ThreadTaskRunnerHandle::Get())) {
+    return false;
+  }
+  {
+    base::MessageLoop::ScopedNestableTaskAllower allow(
+        base::MessageLoop::current());
+    base::RunLoop().RunUntilIdle();
+  }
+  return true;
+}
+
 }  // namespace ui