cc/layer_animation_event_observer.h - Issue 12086018: GTTF: Add missing virtual destructors.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: cc/layer_animation_event_observer.h

Issue 12086018: GTTF: Add missing virtual destructors. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix & rebase Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2012 The Chromium Authors. All rights reserved.	1 // Copyright 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CC_LAYER_ANIMATION_EVENT_OBSERVER_H_	5 #ifndef CC_LAYER_ANIMATION_EVENT_OBSERVER_H_

6 #define CC_LAYER_ANIMATION_EVENT_OBSERVER_H_	6 #define CC_LAYER_ANIMATION_EVENT_OBSERVER_H_

7	7

8 namespace cc {	8 namespace cc {

9	9

10 class CC_EXPORT LayerAnimationEventObserver {	10 class CC_EXPORT LayerAnimationEventObserver {

11 public:	11 public:

	12 virtual ~LayerAnimationEventObserver() { }
	jamesr 2013/02/01 19:30:05 make this protected. client/observer type interfac make this protected. client/observer type interfaces typically don't include ownership, and that's definitely the case here
	13

12 virtual void OnAnimationStarted(const AnimationEvent& event) = 0;	14 virtual void OnAnimationStarted(const AnimationEvent& event) = 0;

13 };	15 };

14	16

15 } // namespace cc	17 } // namespace cc

16	18

17 #endif // CC_LAYER_ANIMATION_EVENT_OBSERVER_H_	19 #endif // CC_LAYER_ANIMATION_EVENT_OBSERVER_H_

18	20

OLD	NEW