Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1208573002: [tools] Add a tool to show potentially missing source deps. (Closed)

Created:
5 years, 6 months ago by Michael Achenbach
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[tools] Add a tool to show potentially missing source deps. NOTRY=true Committed: https://crrev.com/57d1c91cd7402a3cb3163c64e4de3613f165185b Cr-Commit-Position: refs/heads/master@{#29318}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -0 lines) Patch
A tools/verify_source_deps.py View 1 1 chunk +100 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Achenbach
PTAL
5 years, 6 months ago (2015-06-24 14:12:46 UTC) #2
jochen (gone - plz use gerrit)
gn currently doesn't have the tests in it, should we exclude them? Or do you ...
5 years, 6 months ago (2015-06-24 15:00:19 UTC) #3
jochen (gone - plz use gerrit)
lgtm anyway
5 years, 6 months ago (2015-06-24 15:00:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1208573002/20001
5 years, 6 months ago (2015-06-26 10:33:15 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-26 10:35:17 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-26 10:35:36 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/57d1c91cd7402a3cb3163c64e4de3613f165185b
Cr-Commit-Position: refs/heads/master@{#29318}

Powered by Google App Engine
This is Rietveld 408576698