build/android/pylib/instrumentation/test_package.py - Issue 1208483004: Make instrumentation test dependency on a support APK explicit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/instrumentation/test_package.py

Issue 1208483004: Make instrumentation test dependency on a support APK explicit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/instrumentation/test_package.py

diff --git a/build/android/pylib/instrumentation/test_package.py b/build/android/pylib/instrumentation/test_package.py

index f32556f33d00c5fc799a7b28d98adb9a5de31df4..5be061d4af8fb1b3aa9814eed409a4385ca01071 100644

--- a/build/android/pylib/instrumentation/test_package.py

+++ b/build/android/pylib/instrumentation/test_package.py

@@ -16,6 +16,8 @@ class TestPackage(test_jar.TestJar):

if not os.path.exists(apk_path):

raise Exception('%s not found, please build it' % apk_path)

+ if test_support_apk_path and not os.path.exists(test_support_apk_path):

+ raise Exception('%s not found, please build it' % test_support_apk_path)

self._apk_path = apk_path

self._apk_name = os.path.splitext(os.path.basename(apk_path))[0]

self._package_name = apk_helper.GetPackageName(self._apk_path)

« no previous file with comments | « build/android/gyp/create_test_runner_script.py ('k') | build/android/test_runner.gypi » ('j') | no next file with comments »