Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1172)

Unified Diff: build/android/pylib/instrumentation/test_package.py

Issue 1208483004: Make instrumentation test dependency on a support APK explicit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/instrumentation/test_package.py
diff --git a/build/android/pylib/instrumentation/test_package.py b/build/android/pylib/instrumentation/test_package.py
index f32556f33d00c5fc799a7b28d98adb9a5de31df4..c44e16d4432b8dba6f4d04de7346e604da5dfe07 100644
--- a/build/android/pylib/instrumentation/test_package.py
+++ b/build/android/pylib/instrumentation/test_package.py
@@ -1,3 +1,4 @@
+
# Copyright (c) 2013 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
@@ -16,6 +17,8 @@ class TestPackage(test_jar.TestJar):
if not os.path.exists(apk_path):
raise Exception('%s not found, please build it' % apk_path)
+ if not os.path.exists(test_support_apk_path):
jbudorick 2015/06/24 13:05:11 As written, this requires each test apk have a tes
dgn 2015/06/24 14:06:53 Right, we don't. I'm currently rewriting the CL. I
dgn 2015/06/24 16:03:04 Done.
+ raise Exception('%s not found, please build it' % test_support_apk_path)
self._apk_path = apk_path
self._apk_name = os.path.splitext(os.path.basename(apk_path))[0]
self._package_name = apk_helper.GetPackageName(self._apk_path)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698