Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1400)

Side by Side Diff: build/config/android/internal_rules.gni

Issue 1208483004: Make instrumentation test dependency on a support APK explicit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use GYP and GN to set whether the support apk is needed Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 6
7 assert(is_android) 7 assert(is_android)
8 8
9 rebased_android_sdk = rebase_path(android_sdk, root_build_dir) 9 rebased_android_sdk = rebase_path(android_sdk, root_build_dir)
10 rebased_android_sdk_root = rebase_path(android_sdk_root, root_build_dir) 10 rebased_android_sdk_root = rebase_path(android_sdk_root, root_build_dir)
(...skipping 1496 matching lines...) Expand 10 before | Expand all | Expand 10 after
1507 test_runner_args += [ 1507 test_runner_args += [
1508 "--suite", 1508 "--suite",
1509 invoker.test_suite, 1509 invoker.test_suite,
1510 ] 1510 ]
1511 } else if (_test_type == "instrumentation") { 1511 } else if (_test_type == "instrumentation") {
1512 assert(defined(invoker.test_apk)) 1512 assert(defined(invoker.test_apk))
1513 test_runner_args += [ 1513 test_runner_args += [
1514 "--test-apk", 1514 "--test-apk",
1515 invoker.test_apk, 1515 invoker.test_apk,
1516 ] 1516 ]
1517 if (defined(invoker.support_apk)) {
1518 test_runner_args += [
1519 "--support-apk",
1520 invoker.support_apk,
1521 ]
1522 }
1517 } else { 1523 } else {
1518 assert(false, "Invalid test type: $_test_type.") 1524 assert(false, "Invalid test type: $_test_type.")
1519 } 1525 }
1520 1526
1521 if (defined(invoker.isolate_file)) { 1527 if (defined(invoker.isolate_file)) {
1522 test_runner_args += [ 1528 test_runner_args += [
1523 "--isolate-file-path", 1529 "--isolate-file-path",
1524 rebase_path(invoker.isolate_file, root_build_dir), 1530 rebase_path(invoker.isolate_file, root_build_dir),
1525 ] 1531 ]
1526 } 1532 }
1527 1533
1528 generated_script = "$root_build_dir/bin/run_${_test_name}" 1534 generated_script = "$root_build_dir/bin/run_${_test_name}"
1529 outputs = [ 1535 outputs = [
1530 depfile, 1536 depfile,
1531 generated_script, 1537 generated_script,
1532 ] 1538 ]
1533 args = [ 1539 args = [
1534 "--depfile", 1540 "--depfile",
1535 rebase_path(depfile, root_build_dir), 1541 rebase_path(depfile, root_build_dir),
1536 "--script-output-path", 1542 "--script-output-path",
1537 rebase_path(generated_script, root_build_dir), 1543 rebase_path(generated_script, root_build_dir),
1538 ] 1544 ]
1539 args += test_runner_args 1545 args += test_runner_args
1540 } 1546 }
1541 } 1547 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698