Make instrumentation test dependency on a support APK explicit

build/android/test_runner.gypi

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Generates a script in the output bin directory which runs the test
 # target using the test runner script in build/android/pylib/test_runner.py.
 #
 # To use this, include this file in a gtest or instrumentation test target.
 # {
 #   'target_name': 'gtest',
@@ skipping 15 matching lines @@
 #     'isolate_file': 'path/to/instrumentation_test.isolate'  # string
 #   },
 #   'includes': ['path/to/this/gypi/file'],
 # }
 #
 
 {
   'variables': {
     'variables': {
       'isolate_file%': '',
+      'support_apk_name%': '',
     },
     'test_runner_args': ['--output-directory', '<(PRODUCT_DIR)'],
     'conditions': [
       ['test_type == "gtest"', {
         'test_runner_args': ['--suite', '<(test_suite_name)'],
         'script_name': 'run_<(test_suite_name)',
       }],
       ['test_type == "instrumentation"', {
         'test_runner_args': ['--test-apk', '<(apk_name)'],
         'script_name': 'run_<(_target_name)',
+        'conditions': [
+          ['support_apk_name != ""', {
+            'test_runner_args+': ['--support-apk', '<(support_apk_name)'],
+          }],
+        ],
       }],
       ['isolate_file != ""', {
         'test_runner_args': ['--isolate-file-path', '<(isolate_file)']

[dgn, 2015/06/24 16:03:04]

My change works but I don't quite understand how isolate works here... isn't '+'
needed to append? how are both instrumentation and isolate be added to the
script then?

[jbudorick, 2015/06/24 17:46:39]

gyp seems to append to lists even if + isn't included.

       }],
     ],
   },
   'actions': [
     {
       'action_name': 'create_test_runner_script_<(script_name)',
       'message': 'Creating test runner script <(script_name)',
       'variables': {
         'script_output_path': '<(PRODUCT_DIR)/bin/<(script_name)',
       },
       'inputs': [
         '<(DEPTH)/build/android/gyp/create_test_runner_script.py',
       ],
       'outputs': [
         '<(script_output_path)'
       ],
       'action': [
         'python', '<(DEPTH)/build/android/gyp/create_test_runner_script.py',
         '--script-output-path=<(script_output_path)',
         '<(test_type)', '<@(test_runner_args)',
       ],
     },
   ],
 }