Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Side by Side Diff: build/android/pylib/instrumentation/test_package.py

Issue 1208483004: Make instrumentation test dependency on a support APK explicit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: make paths relative to the output directory Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/android/test_runner.gypi » ('j') | build/android/test_runner.gypi » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Class representing instrumentation test apk and jar.""" 5 """Class representing instrumentation test apk and jar."""
6 6
7 import os 7 import os
8 8
9 from pylib.instrumentation import test_jar 9 from pylib.instrumentation import test_jar
10 from pylib.utils import apk_helper 10 from pylib.utils import apk_helper
11 11
12 12
13 class TestPackage(test_jar.TestJar): 13 class TestPackage(test_jar.TestJar):
14 def __init__(self, apk_path, jar_path, test_support_apk_path): 14 def __init__(self, apk_path, jar_path, test_support_apk_path):
15 test_jar.TestJar.__init__(self, jar_path) 15 test_jar.TestJar.__init__(self, jar_path)
16 16
17 if not os.path.exists(apk_path): 17 if not os.path.exists(apk_path):
18 raise Exception('%s not found, please build it' % apk_path) 18 raise Exception('%s not found, please build it' % apk_path)
19 if test_support_apk_path and not os.path.exists(test_support_apk_path):
20 raise Exception('%s not found, please build it' % test_support_apk_path)
19 self._apk_path = apk_path 21 self._apk_path = apk_path
20 self._apk_name = os.path.splitext(os.path.basename(apk_path))[0] 22 self._apk_name = os.path.splitext(os.path.basename(apk_path))[0]
21 self._package_name = apk_helper.GetPackageName(self._apk_path) 23 self._package_name = apk_helper.GetPackageName(self._apk_path)
22 self._test_support_apk_path = test_support_apk_path 24 self._test_support_apk_path = test_support_apk_path
23 25
24 def GetApkPath(self): 26 def GetApkPath(self):
25 """Returns the absolute path to the APK.""" 27 """Returns the absolute path to the APK."""
26 return self._apk_path 28 return self._apk_path
27 29
28 def GetApkName(self): 30 def GetApkName(self):
29 """Returns the name of the apk without the suffix.""" 31 """Returns the name of the apk without the suffix."""
30 return self._apk_name 32 return self._apk_name
31 33
32 def GetPackageName(self): 34 def GetPackageName(self):
33 """Returns the package name of this APK.""" 35 """Returns the package name of this APK."""
34 return self._package_name 36 return self._package_name
35 37
36 # Override. 38 # Override.
37 def Install(self, device): 39 def Install(self, device):
38 device.Install(self.GetApkPath()) 40 device.Install(self.GetApkPath())
39 if (self._test_support_apk_path and 41 if (self._test_support_apk_path and
40 os.path.exists(self._test_support_apk_path)): 42 os.path.exists(self._test_support_apk_path)):
41 device.Install(self._test_support_apk_path) 43 device.Install(self._test_support_apk_path)
42 44
OLDNEW
« no previous file with comments | « no previous file | build/android/test_runner.gypi » ('j') | build/android/test_runner.gypi » ('J')

Powered by Google App Engine
This is Rietveld 408576698