Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(13)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1208443003: Remove unused transformOrigin, shrinking the largest DisplayItem (Closed)

Created:
4 years, 10 months ago by pdr.
Modified:
4 years, 10 months ago
Reviewers:
chrishtr
CC:
blink-reviews, Rik, danakj, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove unused transformOrigin, shrinking the largest DisplayItem Each entry in a ListContainer has enough memory for the largest DisplayItem type. Transform3DDisplayItem was our largest and contained an unused member: m_transformOrigin. This patch removes the unused member which makes the ListContainer more efficient. BUG=484943 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197834

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M Source/platform/graphics/paint/Transform3DDisplayItem.h View 1 chunk +0 lines, -1 line 1 comment Download

Messages

Total messages: 12 (4 generated)
pdr.
4 years, 10 months ago (2015-06-25 04:29:07 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1208443003/1
4 years, 10 months ago (2015-06-25 04:32:30 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2015-06-25 09:02:50 UTC) #6
chrishtr
https://codereview.chromium.org/1208443003/diff/1/Source/platform/graphics/paint/Transform3DDisplayItem.h File Source/platform/graphics/paint/Transform3DDisplayItem.h (left): https://codereview.chromium.org/1208443003/diff/1/Source/platform/graphics/paint/Transform3DDisplayItem.h#oldcode37 Source/platform/graphics/paint/Transform3DDisplayItem.h:37: FloatPoint3D m_transformOrigin; Don't you need to update a constant ...
4 years, 10 months ago (2015-06-25 16:49:16 UTC) #7
pdr.
On 2015/06/25 at 16:49:16, chrishtr wrote: > https://codereview.chromium.org/1208443003/diff/1/Source/platform/graphics/paint/Transform3DDisplayItem.h > File Source/platform/graphics/paint/Transform3DDisplayItem.h (left): > > https://codereview.chromium.org/1208443003/diff/1/Source/platform/graphics/paint/Transform3DDisplayItem.h#oldcode37 ...
4 years, 10 months ago (2015-06-25 16:54:10 UTC) #8
chrishtr
lgtm
4 years, 10 months ago (2015-06-25 16:55:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1208443003/1
4 years, 10 months ago (2015-06-25 16:55:26 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2015-06-25 16:59:16 UTC) #12
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197834

Powered by Google App Engine
This is Rietveld 408576698