Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1208443002: PPC: Do not add extra argument for new.target (Closed)

Created:
5 years, 6 months ago by MTBrandyberry
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Do not add extra argument for new.target Port 8196c28a94f62dec026f2b564ba81d690a4ed593 Original commit message: JSConstructStub for subclass constructors instead locates new.target in a known location on the stack. R=dslomov@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/8636e105d14a5ece02f50e31e4dd3f6dd734150f Cr-Commit-Position: refs/heads/master@{#29254}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -36 lines) Patch
M src/ppc/builtins-ppc.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 4 chunks +0 lines, -13 lines 0 comments Download
M src/ppc/full-codegen-ppc.cc View 5 chunks +27 lines, -20 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
MTBrandyberry
5 years, 6 months ago (2015-06-23 22:00:16 UTC) #1
Dmitry Lomov (no reviews)
lgtm
5 years, 6 months ago (2015-06-24 09:44:44 UTC) #2
dstence
lgtm
5 years, 6 months ago (2015-06-24 13:02:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1208443002/1
5 years, 6 months ago (2015-06-24 13:03:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-24 13:29:15 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 13:29:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8636e105d14a5ece02f50e31e4dd3f6dd734150f
Cr-Commit-Position: refs/heads/master@{#29254}

Powered by Google App Engine
This is Rietveld 408576698