Source/core/paint/DeprecatedPaintLayerScrollableArea.h - Issue 1208433002: Replaced adjustScrollPositionWithinRange with clampScrollPosition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/paint/DeprecatedPaintLayerScrollableArea.h

Issue 1208433002: Replaced adjustScrollPositionWithinRange with clampScrollPosition (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Unremoved DoublePoint version of FrameView::setScrollOffset Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/paint/DeprecatedPaintLayerScrollableArea.h

diff --git a/Source/core/paint/DeprecatedPaintLayerScrollableArea.h b/Source/core/paint/DeprecatedPaintLayerScrollableArea.h

index 85f82981f11a64eb3fb44593fd594f3f0ed8ee48..b268b8a29b1e4278312ba038ffc2d7b461115080 100644

--- a/Source/core/paint/DeprecatedPaintLayerScrollableArea.h

+++ b/Source/core/paint/DeprecatedPaintLayerScrollableArea.h

@@ -223,6 +223,8 @@ private:

void computeScrollDimensions();

+ // TODO(bokan): This method hides the base class version and is subtly different.

+ // Should be unified.

DoubleSize clampScrollOffset(const DoubleSize&) const;

virtual void setScrollOffset(const IntPoint&, ScrollType) override;

« no previous file with comments | « Source/core/loader/FrameLoader.cpp ('k') | Source/platform/scroll/ScrollableArea.h » ('j') | no next file with comments »