Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 1208433002: Replaced adjustScrollPositionWithinRange with clampScrollPosition (Closed)

Created:
4 years, 10 months ago by bokan
Modified:
4 years, 10 months ago
CC:
blink-reviews, gavinp+loader_chromium.org, Nate Chapin, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Replaced adjustScrollPositionWithinRange with clampScrollPosition This change should be a no-op as both methods do the same thing. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197744

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Unremoved DoublePoint version of FrameView::setScrollOffset #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -30 lines) Patch
M Source/core/frame/FrameView.cpp View 1 2 3 chunks +4 lines, -6 lines 0 comments Download
M Source/core/frame/RootFrameViewport.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/loader/FrameLoader.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/DeprecatedPaintLayerScrollableArea.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/platform/scroll/ScrollableArea.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/platform/scroll/ScrollableArea.cpp View 1 2 chunks +1 line, -15 lines 0 comments Download
M Source/web/RotationViewportAnchor.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
bokan
Hey Levi, ptal when you have a chance.
4 years, 10 months ago (2015-06-23 22:10:45 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1208433002/20001
4 years, 10 months ago (2015-06-23 22:11:16 UTC) #4
leviw_travelin_and_unemployed
LGTM. You'll need a Source/web reviewer.
4 years, 10 months ago (2015-06-23 22:21:57 UTC) #6
bokan
On 2015/06/23 22:21:57, leviw wrote: > LGTM. > > You'll need a Source/web reviewer. Joke's ...
4 years, 10 months ago (2015-06-23 22:22:31 UTC) #7
leviw_travelin_and_unemployed
On 2015/06/23 at 22:22:31, bokan wrote: > On 2015/06/23 22:21:57, leviw wrote: > > LGTM. ...
4 years, 10 months ago (2015-06-23 22:35:24 UTC) #8
commit-bot: I haz the power
Dry run: Exceeded global retry quota
4 years, 10 months ago (2015-06-23 22:43:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1208433002/40001
4 years, 10 months ago (2015-06-24 13:52:52 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2015-06-24 15:15:12 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197744

Powered by Google App Engine
This is Rietveld 408576698