Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1470)

Issue 1208423005: [DevTools] Add test checking that codemirror-based highlighter is loaded. (Closed)

Created:
5 years, 5 months ago by dgozman
Modified:
5 years, 5 months ago
Reviewers:
lushnikov
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[DevTools] Add test checking that codemirror-based highlighter is loaded. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198277

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -1 line) Patch
A LayoutTests/inspector/editor/php-highlighter.html View 1 1 chunk +28 lines, -0 lines 0 comments Download
A LayoutTests/inspector/editor/php-highlighter-expected.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
M Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js View 1 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
dgozman
Take a look please.
5 years, 5 months ago (2015-07-03 09:54:40 UTC) #2
lushnikov
lgtm I would also add a test that creates editor and sets mimetype via 'setMimeType' ...
5 years, 5 months ago (2015-07-03 13:13:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1208423005/20001
5 years, 5 months ago (2015-07-03 14:15:23 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/61628)
5 years, 5 months ago (2015-07-03 15:57:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1208423005/20001
5 years, 5 months ago (2015-07-03 16:13:45 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-03 16:38:06 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198277

Powered by Google App Engine
This is Rietveld 408576698