Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 1208413003: Run canary tests in presubmit (Closed)

Created:
5 years, 6 months ago by vsm
Modified:
5 years, 6 months ago
Reviewers:
Leaf, Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Run canary tests in presubmit This partially addresses #128 R=leafp@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/d87a9e4384f0bb27fdf44c1212715b1b6111dcef

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -1 line) Patch
M .travis.yml View 1 chunk +0 lines, -1 line 0 comments Download
A tool/browser_test.sh View 1 chunk +37 lines, -0 lines 0 comments Download
M tool/presubmit.sh View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
vsm
5 years, 6 months ago (2015-06-26 16:47:26 UTC) #2
Leaf
lgtm
5 years, 6 months ago (2015-06-26 16:57:43 UTC) #3
vsm
5 years, 6 months ago (2015-06-26 17:03:19 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d87a9e4384f0bb27fdf44c1212715b1b6111dcef (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698