Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 12084107: Revert 180111, it was not the cause, says isherman@. (Closed)

Created:
7 years, 10 months ago by marja
Modified:
7 years, 10 months ago
Reviewers:
marja
CC:
chromium-reviews, Raman Kakilate, tfarina, benquan, dhollowa+watch_chromium.org, ahutter, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, Albert Bodenhamer, estade+watch_chromium.org, Ilya Sherman
Visibility:
Public.

Description

Revert 180111, it was not the cause, says isherman@. > Tentatively revert 180083 > Some autofill browser_tests on linux_chromeos are failing: > > http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%282%29/builds/11359 > > > [autofill] Hook the sign-in button up to required actions. > > > > - Actually use the info we're getting from wallet to tell whether a user needs > > to authenticate further (in this case only in a non-passive way). > > > > - Add a DialogSignedInState to autofill_dialog_types.h. > > > > - Add a DialogSignedInState SignedInState() to AutofillDialogController interface > > and implements AutofillDialogControllerImpl. > > > > - Adds a UpdateAccountChooser() to AutofillDialogView and implements in > > AutofillDialogViews. > > > > - Use SignedInState() from AutofillDialogViews. > > > > BUG=157270, 163508, 171528 > > R=isherman@chromium.org,sky@chromium.org > > > > Review URL: https://chromiumcodereview.appspot.com/12094069 > > TBR=dbeam@chromium.org > Review URL: https://codereview.chromium.org/12091104 TBR=marja@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180114

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -36 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc View 5 chunks +34 lines, -32 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_types.h View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_view.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/autofill/autofill_dialog_views.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/autofill/autofill_dialog_views.cc View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
marja
7 years, 10 months ago (2013-02-01 09:45:17 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698