Issue 12084091: Prepare push to trunk. Now working on version 3.16.13.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12084091: Prepare push to trunk. Now working on version 3.16.13. (Closed)

Created:
7 years, 10 months ago by Michael Starzinger

Modified:
7 years, 10 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Prepare push to trunk. Now working on version 3.16.13. R=jkummerow@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=13572

Patch Set 2 : Addressed comments. #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	ChangeLog	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
	M	src/version.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with comment. https://codereview.chromium.org/12084091/diff/1/ChangeLog File ChangeLog (right): https://codereview.chromium.org/12084091/diff/1/ChangeLog#newcode3 ChangeLog:3: Parallel and concurrent sweeping (still disabled). ...

7 years, 10 months ago (2013-01-31 18:01:36 UTC) #2

Michael Starzinger

7 years, 10 months ago (2013-02-01 08:54:07 UTC) #3

Addressed comments. Landing.

https://codereview.chromium.org/12084091/diff/1/ChangeLog
File ChangeLog (right):

https://codereview.chromium.org/12084091/diff/1/ChangeLog#newcode3
ChangeLog:3: Parallel and concurrent sweeping (still disabled).
On 2013/01/31 18:01:36, Jakob wrote:
> If it's disabled, why mention it?

Done. Dropped that line.

Expand Messages | Collapse Messages

Issue 12084091: Prepare push to trunk. Now working on version 3.16.13. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed comments. #

Messages